Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(165)

Issue 191640043: Fix failing test on MacOS.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by frankban
Modified:
10 years, 6 months ago
Reviewers:
bac, martin.hilton, mp+246290
Visibility:
Public.

Description

Fix failing test on MacOS. Also update docs to include vivid. Tests: `make check`. No QA required. https://code.launchpad.net/~frankban/juju-quickstart/fix-macosx-failing-test/+merge/246290 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix failing test on MacOS. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M HACKING.rst View 3 chunks +13 lines, -2 lines 0 comments Download
M README.rst View 1 chunk +1 line, -1 line 0 comments Download
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M quickstart/tests/models/test_jenv.py View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 6
frankban
Please take a look.
10 years, 6 months ago (2015-01-13 12:33:49 UTC) #1
bac
LGTM, thanks.
10 years, 6 months ago (2015-01-13 13:02:05 UTC) #2
bac
Verified tests pass on OS X 10.10
10 years, 6 months ago (2015-01-13 13:04:23 UTC) #3
martin.hilton
LGTM
10 years, 6 months ago (2015-01-13 13:41:04 UTC) #4
frankban
*** Submitted: Fix failing test on MacOS. Also update docs to include vivid. Tests: `make ...
10 years, 6 months ago (2015-01-13 13:42:32 UTC) #5
frankban
10 years, 6 months ago (2015-01-13 13:44:41 UTC) #6
Thank you both!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b