Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(242)

Issue 1914044: Sputnik.py

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 9 months ago by pedro.delgallego
Modified:
13 years, 8 months ago
Base URL:
http://sputniktests.googlecode.com/svn/trunk
Visibility:
Public.

Description

This patch allow the launcher to run the code in both strict and no strict mode. When the launcher run in non strict mode the launcher put at the top of the test "var strict_mode = false" but if it runs in strict mode then it inject "use strict" var strict_mode = true. The runner runs each test case twice. Once in strict mode and once in non strict mode. There is also a new metadata that can be add to the test @strict_mode_negative, this metadata is similar to the current @negative, but this one will indicate that the test will fail only in strict mode.

Patch Set 1 #

Patch Set 2 : Two test cases are created (one strict and one non-strict) instead of executing two times the same. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
sputnik.py View 1 6 chunks +23 lines, -3 lines 0 comments Download

Messages

Total messages: 7
pedro.delgallego
13 years, 9 months ago (2010-08-03 23:15:29 UTC) #1
christian.plesner.hansen
Looks good. See comments.
13 years, 9 months ago (2010-08-03 23:32:26 UTC) #2
christian.plesner.hansen
Arg, publishing comments doesn't work. Here are the comments manually. > print "%s was expected ...
13 years, 9 months ago (2010-08-03 23:35:32 UTC) #3
pedro.delgallego
Two test cases are created (one strict and one non-strict) instead of executing two times ...
13 years, 9 months ago (2010-08-04 11:01:50 UTC) #4
pedro.delgallego
> Arg, publishing comments doesn't work. Here are the comments manually. I applied the changes ...
13 years, 9 months ago (2010-08-04 11:04:03 UTC) #5
christian.plesner.hansen
Please add a patch so we have the full history of the change under one ...
13 years, 9 months ago (2010-08-04 11:59:32 UTC) #6
christian.plesner.hansen
13 years, 8 months ago (2010-08-08 01:44:56 UTC) #7
Please add a command-line option that controls whether strict-mode test cases
are used, with a default value of False so the default behavior of the script is
the same as before this change.  I'll coordinate with the v8 team and make sure
they're ready before we enable strict mode tests by default.

Feel free to submit after adding the flag without waiting for another round of
review for this CL.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b