Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(277)

Issue 1909041: [Caja] Ignoring INVALID_CHARACTER_ERR DOMException thrown by createAttribute (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 11 months ago by gagan.goku
Modified:
15 years, 8 months ago
Reviewers:
anupama.dutta, cool-shindig-committers
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

When parsing some web pages, we encounter html attributes which are bad in the sense that Document.createAttribute and Document.createAttributeNS throw DOMException with status code as INVALID_CHARACTER_ERR. This change ignores these attributes and continues parsing.

Patch Set 1 #

Patch Set 2 : updating_DomParser.fixup_to_ignore_bad_attributes #

Patch Set 3 : updating_comment #

Patch Set 4 : fixing_bad_patch #

Patch Set 5 : 'resolving_merge_conflicts_after_svn_up' #

Patch Set 6 : reverting_domparser_change #

Patch Set 7 : updating_with_good_Tests #

Patch Set 8 : more_testing #

Patch Set 9 : removing_unnecessary_rethrow #

Patch Set 10 : fixing_broken_test #

Patch Set 11 : svn upping #

Patch Set 12 : svn upping #

Patch Set 13 : removing extra quote added by mistake #

Patch Set 14 : adding test case for illegal attributes #

Patch Set 15 : cleaning up build.xml #

Patch Set 16 : adding data:hi~ as a bad attribute in DomParserTest #

Patch Set 17 : adding data:hi~ as a bad attribute in DomParserTest #

Patch Set 18 : svn up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -4 lines) Patch
M src/com/google/caja/parser/html/Html5ElementStack.java View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +52 lines, -3 lines 0 comments Download
M tests/com/google/caja/parser/html/DomParserTest.java View 10 11 12 13 14 15 16 17 1 chunk +1 line, -1 line 0 comments Download
A tests/com/google/caja/parser/html/Html5ElementStackTest.java View 6 7 8 12 13 14 15 16 17 1 chunk +93 lines, -0 lines 0 comments Download

Messages

Total messages: 10
anupama.dutta
LGTM. Please add a test and then send for review to dev.remailer, jasvir.
15 years, 11 months ago (2010-07-29 12:55:45 UTC) #1
gagan.goku
On 2010/07/29 12:55:45, anupama.dutta wrote: > LGTM. > Please add a test and then send ...
15 years, 10 months ago (2010-08-09 05:55:04 UTC) #2
gagan.goku
On 2010/08/09 05:55:04, gagan.goku wrote: > On 2010/07/29 12:55:45, anupama.dutta wrote: > > LGTM. > ...
15 years, 10 months ago (2010-08-10 20:29:52 UTC) #3
gagan.goku
15 years, 9 months ago (2010-09-14 03:55:13 UTC) #4
gagan.goku
15 years, 9 months ago (2010-09-14 03:55:48 UTC) #5
gagan.goku
15 years, 9 months ago (2010-09-14 03:57:30 UTC) #6
gagan.goku
15 years, 9 months ago (2010-09-14 04:18:37 UTC) #7
gagan.goku
15 years, 9 months ago (2010-09-14 04:19:47 UTC) #8
gagan.goku
15 years, 9 months ago (2010-09-15 04:12:30 UTC) #9
gagan.goku
15 years, 9 months ago (2010-09-15 04:34:43 UTC) #10

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b