Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(127)

Issue 1904046: Cajoling service should return a 400 if cajoling fails (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 11 months ago by Jasvir
Modified:
15 years, 11 months ago
Reviewers:
MikeSamuel
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

If cajoling fails because there's an error in the input, the cajoler still returns the errors found during cajoling, but now sets the Http status to 400 so that clients that rely on the status can error out early. @4225

Patch Set 1 #

Patch Set 2 : Cajoling service should return a 400 if cajoling fails #

Patch Set 3 : Cajoling service should return a 400 if cajoling fails #

Patch Set 4 : Cajoling service should return a 400 if cajoling fails #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -20 lines) Patch
M src/com/google/caja/service/AbstractCajolingHandler.java View 1 chunk +3 lines, -1 line 0 comments Download
M src/com/google/caja/service/CajolingServlet.java View 2 chunks +5 lines, -1 line 0 comments Download
M src/com/google/caja/service/HtmlHandler.java View 2 chunks +12 lines, -9 lines 0 comments Download
M src/com/google/caja/service/JsHandler.java View 1 chunk +6 lines, -9 lines 0 comments Download
M tests/com/google/caja/service/HtmlHandlerTest.java View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Jasvir
15 years, 11 months ago (2010-08-06 15:39:52 UTC) #1
MikeSamuel
15 years, 11 months ago (2010-08-06 21:59:31 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b