Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2896)

Issue 1903041: Convenient way to set shindig.host and shindig.port in web.xml

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 9 months ago by Han Nguyen
Modified:
13 years, 8 months ago
Reviewers:
Paul Lindner, dev-remailer
Base URL:
Shindig 2.0.0
Visibility:
Public.

Description

In addition to specifying the shindig.host -Dshindig.host=`hostname` to your server startup script. This patch allows users a way to conveniently select a shindig.host and shindig.port that shindig WAR is deployed on from a specified list in the web.xml <context-param/>

Patch Set 1 #

Patch Set 2 : Updated the patch to inject a map of System Properties via web.xml #

Patch Set 3 : Added code to check for empty System Properties list from the web.xml #

Patch Set 4 : Updated patch per Paul's feedbacks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -2 lines) Patch
java/common/src/main/java/org/apache/shindig/common/servlet/GuiceServletContextListener.java View 1 2 3 2 chunks +29 lines, -2 lines 0 comments Download
java/server/src/main/webapp/WEB-INF/web.xml View 1 2 3 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 9
Han Nguyen
13 years, 9 months ago (2010-07-26 14:00:13 UTC) #1
Han Nguyen
Updated the patch to inject a map of System Properties via web.xml
13 years, 8 months ago (2010-08-09 15:55:23 UTC) #2
Han Nguyen
Updated the patch to inject a map of System Properties via web.xml
13 years, 8 months ago (2010-08-09 16:14:14 UTC) #3
Han Nguyen
Updated the patch to inject a map of System Properties via web.xml
13 years, 8 months ago (2010-08-09 16:51:01 UTC) #4
Han Nguyen
On 2010/08/09 16:51:01, Han Nguyen wrote: > Updated the patch to inject a map of ...
13 years, 8 months ago (2010-08-09 16:57:05 UTC) #5
Han Nguyen
Added code to check for empty System Properties list from the web.xml
13 years, 8 months ago (2010-08-19 18:00:03 UTC) #6
Paul Lindner
for some reason I can't comment on individual code chunks. Here are some suggestions: * ...
13 years, 8 months ago (2010-08-25 14:06:53 UTC) #7
Han Nguyen
Updated patch per Paul's feedbacks
13 years, 8 months ago (2010-08-27 16:35:06 UTC) #8
Paul Lindner
13 years, 8 months ago (2010-08-27 20:51:57 UTC) #9
committed.  Thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b