code review 19010044: misc/emacs: various cleanups

misc/emacs: various cleanups

- Use #' for function symbols
- Remove unused variables
- Use declare-function to shut up byte compiler

[Dominik Honnef, 2013-10-29 16:41:00]

Hello adonovan@google.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[adonovan, 2013-10-29 17:06:29]

LGTM

https://codereview.appspot.com/19010044/diff/2/misc/emacs/go-mode.el
File misc/emacs/go-mode.el (left):

https://codereview.appspot.com/19010044/diff/2/misc/emacs/go-mode.el#oldcode393
misc/emacs/go-mode.el:393: (let (start-nesting (outindent 0))
I initially misread that as
  (let ((start-nesting (outindent 0))

One let binding per line is a good rule.

https://codereview.appspot.com/19010044/diff/2/misc/emacs/go-mode.el
File misc/emacs/go-mode.el (right):

https://codereview.appspot.com/19010044/diff/2/misc/emacs/go-mode.el#newcode43
misc/emacs/go-mode.el:43: (if (fboundp #'kill-whole-line)
(Strictly speaking, you don't want it for fboundp, but it's harmless.)

[adonovan, 2013-10-29 17:07:53]

*** Submitted as https://code.google.com/p/go/source/detail?r=dbcd720e5396 ***

misc/emacs: various cleanups

- Use #' for function symbols
- Remove unused variables
- Use declare-function to shut up byte compiler

R=adonovan
CC=golang-dev
https://codereview.appspot.com/19010044

Committer: Alan Donovan <adonovan@google.com>

[Dominik Honnef, 2013-10-29 17:08:38]

https://codereview.appspot.com/19010044/diff/2/misc/emacs/go-mode.el
File misc/emacs/go-mode.el (right):

https://codereview.appspot.com/19010044/diff/2/misc/emacs/go-mode.el#newcode43
misc/emacs/go-mode.el:43: (if (fboundp #'kill-whole-line)
On 2013/10/29 17:06:29, adonovan wrote:
> (Strictly speaking, you don't want it for fboundp, but it's harmless.)

I feel like people who only know Elisp and none of the other lisps have a really
hard time with this, since nothing anywhere really talks about those things.

[adonovan, 2013-10-29 17:10:24]

On 29 October 2013 13:08, <dominik.honnef@gmail.com> wrote:

> On 2013/10/29 17:06:29, adonovan wrote:
>
>> (Strictly speaking, you don't want it for fboundp, but it's harmless.)
>>
>
> I feel like people who only know Elisp and none of the other lisps have
> a really hard time with this, since nothing anywhere really talks about
> those things.


Fair point; luckily elisp is very forgiving of mistakes of this kind so I
wouldn't sweat it.

[bradfitz, 2013-10-30 01:56:49]

Please revert this, or fix it soon.  It breaks go-mode on GNU Emacs 22.1.1 as
ships with OS X 10.8.6.

[bradfitz, 2013-10-30 01:57:16]

(no declare-function)

[adonovan, 2013-10-30 02:18:07]

Rolled back as
https://code.google.com/p/go/**source/detail?r=b0e2a2083d0c<https://code.goog...



On 29 October 2013 21:57, <bradfitz@golang.org> wrote:

> (no declare-function)
>
>
>
https://codereview.appspot.**com/19010044/<https://codereview.appspot.com/190...
>