Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(97)

Issue 189760043: [release-branch.go1.4] code review 189760043: cmd/go: document import path checking (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by rsc
Modified:
10 years, 2 months ago
Reviewers:
adg1, shurcooL
CC:
adg, adg1, golang-codereviews
Visibility:
Public.

Description

cmd/go: document import path checking

Patch Set 1 #

Patch Set 2 : diff -r b5c6a4abeb4cdb46c7c5824ffb14fa1697a0b82d https://code.google.com/p/go/ #

Patch Set 3 : diff -r b5c6a4abeb4cdb46c7c5824ffb14fa1697a0b82d https://code.google.com/p/go/ #

Patch Set 4 : diff -r b5c6a4abeb4cdb46c7c5824ffb14fa1697a0b82d https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -3 lines) Patch
M src/cmd/go/doc.go View 1 2 3 1 chunk +20 lines, -1 line 0 comments Download
M src/cmd/go/help.go View 1 2 1 chunk +20 lines, -1 line 0 comments Download
M src/cmd/go/mkdoc.sh View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
rsc
Hello adg (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the release-branch.go1.4 branch ...
10 years, 3 months ago (2014-12-09 02:49:22 UTC) #1
adg1
LGTM But don't forget to run mkdoc.sh and hg add doc.go.
10 years, 3 months ago (2014-12-09 03:00:54 UTC) #2
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=c52af0807cc3 *** [release-branch.go1.4] cmd/go: document import path checking LGTM=adg R=adg CC=golang-codereviews https://codereview.appspot.com/189760043
10 years, 3 months ago (2014-12-09 03:26:00 UTC) #3
rsc
I had to change mkdoc.sh to turn the */ into a * / to avoid ...
10 years, 3 months ago (2014-12-09 03:26:40 UTC) #4
adg1
OK We just tested; godoc handles /* Several comments */ // interspersed with lines like ...
10 years, 3 months ago (2014-12-09 03:31:26 UTC) #5
shurcooL
Hi, I wanted to file an issue related to this section, which is now a ...
10 years, 2 months ago (2015-01-08 04:47:13 UTC) #6
adg1
10 years, 2 months ago (2015-01-09 02:38:51 UTC) #7
Minux fixed this, thanks for pointing it out.

On 8 January 2015 at 15:47, <shurcooL@gmail.com> wrote:

> Hi, I wanted to file an issue related to this section, which is now a
> part of the official release docs:
>
> http://golang.org/cmd/go/#hdr-Import_path_checking
>
> However I noticed that section is not present on
> http://tip.golang.org/cmd/go/. I then realized it's because this
> CL/commit,
>
> https://github.com/golang/go/commit/05560adf6246251d084fc08a427ebc
> a7bf1513a1
>
> Is only on release-branch.go1.4 branch and not master/tip.
>
> My questions are, shouldn't it or a similar commit be on tip? Can I
> still file an issue about (an inconsistency) its contents?
>
>
> On 2014/12/09 03:31:26, adg1 wrote:
>
>> OK
>>
>
>  We just tested; godoc handles
>>
>
>  /*
>> Several comments
>> */
>> // interspersed with lines like this
>> /*
>> as a single doc comment.
>> */
>>
>
>  On 9 December 2014 at 14:26, Russ Cox <mailto:rsc@golang.org> wrote:
>>
>
>  > I had to change mkdoc.sh to turn the */ into a * / to avoid
>>
> terminating
>
>> > the comment. It's ugly but good enough for now.
>> >
>> >
>>
>
>
> https://codereview.appspot.com/189760043/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b