Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2128)

Issue 189520045: Enhancement: LilyPond-mode for packaging emacs 24

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 4 months ago by pkx166h
Modified:
9 years, 4 months ago
Reviewers:
dak, pschmied
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Enhancement: LilyPond-mode for packaging emacs 24 Issue 4230 Ready lilypond-mode for packaging for emacs 24 package system, such that lilypond-mode will work with Melpa.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+975 lines, -949 lines) Patch
M elisp/lilypond-font-lock.el View 4 chunks +52 lines, -50 lines 0 comments Download
M elisp/lilypond-indent.el View 14 chunks +306 lines, -304 lines 0 comments Download
M elisp/lilypond-init.el View 2 chunks +12 lines, -6 lines 0 comments Download
M elisp/lilypond-mode.el View 36 chunks +442 lines, -433 lines 1 comment Download
A elisp/lilypond-mode-pkg.el View 1 chunk +3 lines, -0 lines 0 comments Download
M elisp/lilypond-song.el View 3 chunks +28 lines, -26 lines 0 comments Download
M elisp/lilypond-what-beat.el View 10 chunks +132 lines, -130 lines 0 comments Download

Messages

Total messages: 4
pkx166h
Patch on countdown for Jan 13th
9 years, 4 months ago (2015-01-11 17:17:01 UTC) #1
dak
https://codereview.appspot.com/189520045/diff/1/elisp/lilypond-mode.el File elisp/lilypond-mode.el (right): https://codereview.appspot.com/189520045/diff/1/elisp/lilypond-mode.el#newcode165 elisp/lilypond-mode.el:165: (setq currword (car co)) Is there a reason you ...
9 years, 4 months ago (2015-01-16 09:36:06 UTC) #2
pkx166h
Peter, see David's comments and you can give me a new patch when you are ...
9 years, 4 months ago (2015-01-16 09:48:05 UTC) #3
pschmied
9 years, 4 months ago (2015-01-16 14:03:40 UTC) #4
On 2015/01/16 09:48:05, J_lowe wrote:
> Peter, see David's comments and you can give me a new patch when you are ready
> for me to resubmit.
> 
> James

Hmm... That probably happened when I tried to get rid of the trailing whitespace
that patch complained about. I'll see if I can figure out how to do both this
weekend.

-p
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b