Issue 189075: Fix two issues with protobufs on Windows:

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 189075: Fix two issues with protobufs on Windows:

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by nickcarter

Modified:
14 years, 3 months ago

Reviewers:
kenton

CC:
chromium-reviews_googlegroups.com, protobuf_googlegroups.com

Base URL:
http://protobuf.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Fix two issues with protobufs on Windows: [1] subprocess.cc wouldn't compile if UNICODE was defined. Explicitly call the ASCII variant. This is issue 157: http://code.google.com/p/protobuf/issues/detail?id=157 [2] Move the windows.h GetMessage name-collision workaround into the common header, so that the workaround is visible to both extension_set.h and message.h. Both of those headers declare methods named GetMessage. This is issue 156: http://code.google.com/p/protobuf/issues/detail?id=156

Patch Set 1 #

Patch Set 2 : '' #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -30 lines)			Patch
M	src/google/protobuf/compiler/subprocess.cc	View	1	2 chunks	+11 lines, -11 lines	0 comments	Download
M	src/google/protobuf/message.h	View		1 chunk	+0 lines, -19 lines	0 comments	Download
M	src/google/protobuf/stubs/common.h	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

nickcarter

Hi Kenton, This patch fixes the two issues I reported. Nick

14 years, 3 months ago (2010-01-14 21:53:19 UTC) #1

kenton

14 years, 3 months ago (2010-01-15 02:29:45 UTC) #2

Ahhh, someone who knows the process.

Looks great!  Committed as rev 305.

Expand All Messages | Collapse All Messages