Issue 188890043: Add the Juju version to the GUI config file.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 188890043: Add the Juju version to the GUI config file.

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 4 months ago by frankban

Modified:
9 years, 4 months ago

Reviewers:
rharding, mp+244273

Visibility:
Public.

Description

Add the Juju version to the GUI config file. The version can be specified using a charm option. If not specified, the Juju version is retrieved dynamically by calling jujud --version. Initial implementation by Huw. Tests: `make unittest`. QA: - bootstrap an environment; - run `make deploy`; - wait for the unit to be ready; - run `juju ssh juju-gui/0 cat /var/lib/juju-gui/juju-gui/build-prod/juju-ui/assets/config.js` and check the Juju version is included in the config file; - run `juju set juju-gui juju-core-version=42.47`; - check the version is changed to the one specified; - run `juju unset juju-gui juju-core-version`; - check the correct version is back in the config file; - destroy the environment. Done, thank you! https://code.launchpad.net/~frankban/charms/trusty/juju-gui/config-version/+merge/244273 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Add the Juju version to the GUI config file. #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -2 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	config.yaml	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	config/config.js.template	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	hooks/backend.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	hooks/utils.py	View	3 chunks	+5 lines, -1 line	0 comments	Download
M	tests/test_backends.py	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	tests/test_utils.py	View	3 chunks	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rharding

On 2014/12/10 13:10:40, rharding wrote: > :+1: will QA QA OK thank you! LGTM

9 years, 4 months ago (2014-12-10 13:51:59 UTC) #3

frankban

9 years, 4 months ago (2014-12-10 14:03:56 UTC) #5

*** Submitted:

Add the Juju version to the GUI config file.

The version can be specified using a charm option.
If not specified, the Juju version is retrieved 
dynamically by calling jujud --version.

Initial implementation by Huw.

Tests: `make unittest`.

QA:
- bootstrap an environment;
- run `make deploy`;
- wait for the unit to be ready;
- run `juju ssh juju-gui/0 cat
/var/lib/juju-gui/juju-gui/build-prod/juju-ui/assets/config.js`
  and check the Juju version is included in the config file;
- run `juju set juju-gui juju-core-version=42.47`;
- check the version is changed to the one specified;
- run `juju unset juju-gui juju-core-version`;
- check the correct version is back in the config file;
- destroy the environment.

Done, thank you!

R=rharding
CC=
https://codereview.appspot.com/188890043

Expand All Messages | Collapse All Messages