Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(392)

Issue 188730043: [dev.garbage] code review 188730043: runtime: raise StackGuard limit for Windows (again) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by rsc
Modified:
10 years, 6 months ago
Reviewers:
Mike.Rosset, rlh
CC:
golang-codereviews
Visibility:
Public.

Description

runtime: raise StackGuard limit for Windows (again) 640 bytes ought to be enough for anybody. We'll bring this back down before Go 1.5. That's issue 9214.

Patch Set 1 #

Patch Set 2 : diff -r 74050a65a1bb8d6d6fc9892f9ce8783201b121cc https://code.google.com/p/go/ #

Patch Set 3 : diff -r 74050a65a1bb8d6d6fc9892f9ce8783201b121cc https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/runtime/stack.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/stack2.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/nosplit.go View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello rlh (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.garbage branch ...
10 years, 6 months ago (2014-12-06 00:50:08 UTC) #1
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=d1238958d4ae *** [dev.garbage] runtime: raise StackGuard limit for Windows (again) 640 bytes ...
10 years, 6 months ago (2014-12-06 00:50:14 UTC) #2
Mike.Rosset
On 2014/12/06 00:50:14, rsc wrote: > *** Submitted as https://code.google.com/p/go/source/detail?r=d1238958d4ae *** > > [dev.garbage] runtime: ...
10 years, 6 months ago (2014-12-06 02:06:29 UTC) #3
rlh
10 years, 6 months ago (2014-12-06 16:56:02 UTC) #4
Message was sent while issue was closed.
On 2014/12/06 02:06:29, Mike.Rosset wrote:
> On 2014/12/06 00:50:14, rsc wrote:
> > *** Submitted as https://code.google.com/p/go/source/detail?r=d1238958d4ae
***
> > 
> > [dev.garbage] runtime: raise StackGuard limit for Windows (again)
> > 
> > 640 bytes ought to be enough for anybody.
> > 
> > We'll bring this back down before Go 1.5. That's issue 9214.
> > 
> > TBR=rlh
> > CC=golang-codereviews
> > https://codereview.appspot.com/188730043
> 
> oh the irony!

LGTM
Not sure what the GC did to cause this but more memory is an indulgence that can
hide many sins.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b