Issue 188580043: property to set voiced-rest positions; issue 3902

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 188580043: property to set voiced-rest positions; issue 3902

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 4 months ago by Keith

Modified:
9 years, 4 months ago

Reviewers:
dak, Trevor Daniels

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

property to set voiced-rest positions; issue 3902

Patch Set 1 #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -10 lines)			Patch
M	input/regression/rest-polyphonic.ly	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	lily/rest.cc	View	5 chunks	+10 lines, -9 lines	1 comment	Download
M	scm/define-grob-properties.scm	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	scm/define-grobs.scm	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dak

https://codereview.appspot.com/188580043/diff/1/lily/rest.cc File lily/rest.cc (right): https://codereview.appspot.com/188580043/diff/1/lily/rest.cc#newcode75 lily/rest.cc:75: Real vpos = dir * robust_scm2int (me->get_property ("voiced-position"), 0); ...

9 years, 4 months ago (2015-01-04 11:24:20 UTC) #1

Keith

> Shouldn't the fallback remain 4 rather than 0? Either one. I couldn't decide. If ...

9 years, 4 months ago (2015-01-06 05:07:46 UTC) #2

LGTM

Trevor

Expand All Messages | Collapse All Messages