Magento unused variables and modules removed by Matrixise

This is a patch forwarded by Stephane Wirtel (Open ERP). I think its better to review the code before we merge.

I think I have marked CC to all involved.

Thanks,

[stephane.wirtel, 2010-08-09 14:05:22]

http://codereview.appspot.com/1884051/diff/1/2
File 'delivery.py' (left):

http://codereview.appspot.com/1884051/diff/1/2#oldcode29
'delivery.py':29: 'magento_code': fields.char('Magento Carrier Code', size=64,
required=True),
For this patch of code, I discussed with Sebastien Beau from Akretion, because
the required fields don't have any default values.

[sharoonthomas, 2010-08-09 14:09:02]

http://codereview.appspot.com/1884051/diff/1/2
File 'delivery.py' (left):

http://codereview.appspot.com/1884051/diff/1/2#oldcode29
'delivery.py':29: 'magento_code': fields.char('Magento Carrier Code', size=64,
required=True),
On 2010/08/09 14:05:22, stephane.wirtel wrote:
> For this patch of code, I discussed with Sebastien Beau from Akretion, because
> the required fields don't have any default values.

We have to hope this does not break anything else as there are no unit tests :(

http://codereview.appspot.com/1884051/diff/1/4
File 'magerp_osv.py' (right):

http://codereview.appspot.com/1884051/diff/1/4#newcode3
'magerp_osv.py':3: import netsvc
If this cleanup is in accordance with PEP008 then netsvc has to be below as well

[stephane.wirtel, 2010-08-09 14:11:58]

On 2010/08/09 14:09:02, sharoonthomas wrote:
> http://codereview.appspot.com/1884051/diff/1/2
> File 'delivery.py' (left):
> 
> http://codereview.appspot.com/1884051/diff/1/2#oldcode29
> 'delivery.py':29: 'magento_code': fields.char('Magento Carrier Code', size=64,
> required=True),
> On 2010/08/09 14:05:22, stephane.wirtel wrote:
> > For this patch of code, I discussed with Sebastien Beau from Akretion,
because
> > the required fields don't have any default values.
> 
> We have to hope this does not break anything else as there are no unit tests
:(
> 
> http://codereview.appspot.com/1884051/diff/1/4
> File 'magerp_osv.py' (right):
> 
> http://codereview.appspot.com/1884051/diff/1/4#newcode3
> 'magerp_osv.py':3: import netsvc
> If this cleanup is in accordance with PEP008 then netsvc has to be below as
well
agree with you, but in this case, I used pyflakes and not an other validator or
python checker tools.

So, you can change the patch if you want, 

Regards,