Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1886)

Issue 188350043: Fix tests due to Firefox function property changes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 4 months ago by kpreid_google
Modified:
9 years, 4 months ago
Reviewers:
ihab.awad
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fixes <https://code.google.com/p/google-caja/issues/detail?id=1948>. All test failures were due to harmless behavior changes in Firefox that broke assumptions made by the tests. See <https://code.google.com/p/google-caja/issues/detail?id=1947> for information on the Firefox changes (function instances no longer have the caller and arguments properties). Additionally, increase the timeout for guest-scan test. It takes a very long time when running on Firefox _under webdriver_. Would like to fix it, but for now, accept it. @r5706

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M tests/com/google/caja/plugin/MainBrowserTest.java View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/com/google/caja/plugin/test-scan-guest.js View 1 chunk +4 lines, -6 lines 0 comments Download
M tests/com/google/caja/plugin/test-taming-tamed-guest.html View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 2
kpreid_google
9 years, 4 months ago (2014-12-17 22:10:06 UTC) #1
ihab.awad
9 years, 4 months ago (2014-12-17 22:47:27 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b