Issue 1883042: Fixing small error in PropertiesModule

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1883042: Fixing small error in PropertiesModule (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 3 months ago by gagan.goku

Modified:
16 years, 3 months ago

Reviewers:
dev-remailer

CC:
cool-shindig-committers_googlegroups.com

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk

Visibility:
Public.

Description

Fixing small compilation error in PropertiesModule.

Patch Set 1 #

Created: 16 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
		java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

plindner_linkedin.com

I broke this, but was, waiting for apache svn to go read/write... It's back now ...

16 years, 3 months ago (2010-07-24 04:12:56 UTC) #2

gagan.goku

16 years, 3 months ago (2010-07-24 04:23:23 UTC) #3

Thanks Paul

On Sat, Jul 24, 2010 at 9:42 AM, Paul Lindner <plindner@linkedin.com> wrote:

> I broke this, but was, waiting for apache svn to go read/write...  It's
> back now -- committed.
>
>
> On Fri, Jul 23, 2010 at 8:48 PM, <gagan.goku@gmail.com> wrote:
>
>> Reviewers: dev-remailer_shindig.apache.org,
>>
>>
>>
>> Please review this at http://codereview.appspot.com/1883042/show
>>
>> Affected files:
>>  java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java
>>
>>
>> Index:
>> java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java
>> ===================================================================
>> ---
>> java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java
>> (revision 978785)
>> +++
>> java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java
>> (working copy)
>> @@ -81,7 +81,7 @@
>>
>>   protected String getServerHostname() {
>>     return System.getProperty("shindig.host") != null ?
>> System.getProperty("shindig.host") :
>> -    return System.getProperty("jetty.host") != null ?
>> System.getProperty("jetty.host") :
>> +           System.getProperty("jetty.host") != null ?
>> System.getProperty("jetty.host") :
>>       "localhost";
>>   }
>>
>>
>>
>>
>

Expand All Messages | Collapse All Messages