Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(37)

Issue 187880044: full duplex extensions for CSMA

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 3 months ago by Tom Henderson
Modified:
4 years, 2 months ago
Reviewers:
joao, Luciano Chaves
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

This is a continuation of issue https://codereview.appspot.com/5615049/ This code can be tested by checking out http://code.nsnam.org/tomh/ns-3-dev-csmafd There seem to be basically two existing issues to resolve before trying to merge this. 1) Hugo Pinto raised some questions about possible bugs in the previous review issue here: https://codereview.appspot.com/5615049/#msg28 2) I have asked for some test cases and tests A third issue that I'll ask now is whether to just default the ns-3 implementation to use full duplex mode. This patch requires the user to explicitly enable it.

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -68 lines) Patch
M src/csma/model/csma-channel.h View 10 chunks +102 lines, -13 lines 0 comments Download
M src/csma/model/csma-channel.cc View 14 chunks +88 lines, -30 lines 4 comments Download
M src/csma/model/csma-net-device.cc View 9 chunks +39 lines, -25 lines 1 comment Download

Messages

Total messages: 4
Luciano Chaves
Hi, About the full-duplex extension for CSMA, questions raised by Hugo at https://codereview.appspot.com/5615049/#msg28 are relevant. ...
5 years ago (2016-02-24 16:03:05 UTC) #1
joao
https://codereview.appspot.com/187880044/diff/1/src/csma/model/csma-channel.cc File src/csma/model/csma-channel.cc (right): https://codereview.appspot.com/187880044/diff/1/src/csma/model/csma-channel.cc#newcode195 src/csma/model/csma-channel.cc:195: if (GetState (srcId) != IDLE) Can't a transmission start ...
4 years, 6 months ago (2016-08-13 23:21:56 UTC) #2
Luciano Chaves
https://codereview.appspot.com/187880044/diff/1/src/csma/model/csma-channel.cc File src/csma/model/csma-channel.cc (right): https://codereview.appspot.com/187880044/diff/1/src/csma/model/csma-channel.cc#newcode195 src/csma/model/csma-channel.cc:195: if (GetState (srcId) != IDLE) On 2016/08/13 23:21:56, joao ...
4 years, 6 months ago (2016-08-15 18:00:25 UTC) #3
Luciano Chaves
4 years, 2 months ago (2017-01-05 17:14:02 UTC) #4
A revised patch for this extension, including updated documentation and an
example was submitted to https://www.nsnam.org/bugzilla/show_bug.cgi?id=2354.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b