Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(16875)

Issue 1878043: tests: add simple mocking tests for http and socks proxy support

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 9 months ago by Augie fackler
Modified:
8 years, 4 months ago
Reviewers:
jcgregorio
CC:
httplib2-dev_googlegroups.com
Visibility:
Public.

Description

tests: add simple mocking tests for http and socks proxy support REV=9cb5fa71c931

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -0 lines) Patch
A python2/httplib2/test/proxy_mock_test.py View 1 chunk +88 lines, -0 lines 0 comments Download
A python2/httplib2/test/util.py View 1 chunk +129 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Augie fackler
13 years, 9 months ago (2010-07-25 21:13:02 UTC) #1
jcgregorio
Just a note that the current use of socks.py doesn't play well with App Engine: ...
13 years, 7 months ago (2010-09-08 14:40:17 UTC) #2
Augie fackler
13 years, 6 months ago (2010-10-05 13:13:17 UTC) #3
Just uploaded a new changeset that should fix this and add a test for the
problem. The test is a little hairy.

On Sep 8, 2010, at 9:40 AM, joe.gregorio@gmail.com wrote:

> Just a note that the current use of socks.py doesn't play well with App
> Engine:
> 
>  File
>
"/usr/local/google/home/jcgregorio/projects/apiary/samples/appengine/httplib2/socks.py",
> line 137, in <module>
>    class socksocket(socket.socket):
> AttributeError: 'module' object has no attribute 'socket'
> 
> 
> http://codereview.appspot.com/1878043/

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b