Issue 187380044: credentials_lib should not use a proxy for calls to metadata server, ever.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by thobrla

Modified:
11 years, 3 months ago

Reviewers:
craigcitro-work

CC:
jterrace, Mike Schwartz, bigstore-team+cr_google.com

Visibility:
Public.

credentials_lib should not use a proxy for calls to metadata server, ever.

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	gslib/third_party/storage_apitools/credentials_lib.py	View		3 chunks	+4 lines, -3 lines	0 comments	Download
	M	gslib/third_party/storage_apitools/util.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 2

craigcitro-work

11 years, 3 months ago (2015-01-13 21:16:40 UTC) #2

LGTM -- can you file an issue at https://github.com/google/oauth2client to
replicate this there, too?