QNX build is broken

[Billy Donahue, 2013-11-05 18:18:29]

On 2013/10/31 19:00:47, efidler1 wrote:
>


Thanks, but can I get some details? Maybe a dump of your compile errors?

[Billy Donahue, 2013-11-05 18:18:50]

https://codereview.appspot.com/18730043/diff/1/src/gtest-printers.cc
File src/gtest-printers.cc (right):

https://codereview.appspot.com/18730043/diff/1/src/gtest-printers.cc#newcode50
src/gtest-printers.cc:50: #include <wchar.h>
#include <cwchar>

[efidler1, 2013-11-05 18:22:00]

On 2013/11/05 18:18:29, billydonahue wrote:
> On 2013/10/31 19:00:47, efidler1 wrote:
> >
> 
> 
> Thanks, but can I get some details? Maybe a dump of your compile errors?

details are on the bug:
https://code.google.com/p/googletest/issues/detail?id=444

[efidler1, 2013-11-05 18:24:05]

https://codereview.appspot.com/18730043/diff/1/src/gtest-printers.cc
File src/gtest-printers.cc (right):

https://codereview.appspot.com/18730043/diff/1/src/gtest-printers.cc#newcode50
src/gtest-printers.cc:50: #include <wchar.h>
On 2013/11/05 18:18:50, billydonahue wrote:
> #include <cwchar>

gtest-printers.cpp uses wcslen(), but on QNX "#include <cwchar>" only defines
std::wcslen().

[Billy Donahue, 2013-11-05 18:39:41]

Can you change gtest-printers.cpp to use std::wcslen() ?


On Tue, Nov 5, 2013 at 1:24 PM, <efidler@blackberry.com> wrote:

>
> https://codereview.appspot.com/18730043/diff/1/src/gtest-printers.cc
> File src/gtest-printers.cc (right):
>
> https://codereview.appspot.com/18730043/diff/1/src/gtest-
> printers.cc#newcode50
> src/gtest-printers.cc:50: #include <wchar.h>
> On 2013/11/05 18:18:50, billydonahue wrote:
>
>> #include <cwchar>
>>
>
> gtest-printers.cpp uses wcslen(), but on QNX "#include <cwchar>" only
> defines std::wcslen().
>
> https://codereview.appspot.com/18730043/
>

[efidler1, 2013-11-05 18:44:34]

On 2013/11/05 18:39:41, billydonahue wrote:
> Can you change gtest-printers.cpp to use std::wcslen() ?


Sure. Patch coming.

[efidler1, 2013-11-11 17:27:39]

uploaded

[Billy Donahue, 2013-11-11 19:06:31]

You have to #include <wcslen> to use std::wcslen. I don't see where that's
happening.

https://codereview.appspot.com/18730043/diff/20001/src/gtest-printers.cc
File src/gtest-printers.cc (right):

https://codereview.appspot.com/18730043/diff/20001/src/gtest-printers.cc#newc...
src/gtest-printers.cc:332: PrintCharsAsStringTo(s, std::wcslen(s), os);
You have to #include <cwchar> to get std::wcslen, don't you?

[efidler1, 2013-11-11 19:10:04]

> You have to #include <cwchar> to get std::wcslen, don't you?

#include <string> gets that implicitly for me, but I guess it's safer to be
explicit.

[efidler1, 2013-11-15 15:54:00]

ptal

[efidler1, 2013-11-21 19:59:35]

ptal again

[Billy Donahue, 2013-12-06 19:40:26]

On 2013/11/21 19:59:35, efidler1 wrote:
> ptal again

LGTM.
Not sure how to get this in though.

[Billy Donahue, 2013-12-06 19:52:21]

Nevermind. I figured out how to integrate it into our HEAD branch.
It's on the way.


On Fri, Dec 6, 2013 at 2:40 PM, <billydonahue@google.com> wrote:

> On 2013/11/21 19:59:35, efidler1 wrote:
>
>> ptal again
>>
>
> LGTM.
> Not sure how to get this in though.
>
> https://codereview.appspot.com/18730043/
>

[efidler1, 2014-02-12 21:51:14]

Did you ever get a chance to integrate this fix? I can't find it in the repo.

[efidler1, 2014-02-20 17:53:12]

billydonahue? I want to make sure this doesn't get lost.

[Billy Donahue, 2014-02-20 18:22:37]

On 2014/02/20 17:53:12, efidler1 wrote:
> billydonahue? I want to make sure this doesn't get lost.

Sorry, I dropped this. I'll do it.

[efidler1, 2014-03-07 22:57:53]

On 2014/02/20 18:22:37, billydonahue wrote:
> On 2014/02/20 17:53:12, efidler1 wrote:
> > billydonahue? I want to make sure this doesn't get lost.
> 
> Sorry, I dropped this. I'll do it.

Sorry to bug, but I still don't see this patch in the repo.

[Billy Donahue, 2014-03-08 01:50:48]

yes. you are 100% right to ping this. Thanks.


On Friday, March 7, 2014, <efidler@blackberry.com> wrote:

> On 2014/02/20 18:22:37, billydonahue wrote:
>
>> On 2014/02/20 17:53:12, efidler1 wrote:
>> > billydonahue? I want to make sure this doesn't get lost.
>>
>
>  Sorry, I dropped this. I'll do it.
>>
>
> Sorry to bug, but I still don't see this patch in the repo.
>
> https://codereview.appspot.com/18730043/
>