Issue 1868047: code review 1868047: runtime: fix goc2c for rename to goc2c and *.goc

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1868047: code review 1868047: runtime: fix goc2c for rename to goc2c and *.goc

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by peterGo

Modified:
13 years, 9 months ago

Reviewers:
rsc

CC:
rsc, golang-dev

Visibility:
Public.

Description

runtime: fix goc2c for rename to goc2c and *.goc Release 2010-04-27. runtime: rename cgo2c, *.cgo to goc2c, *.goc to avoid confusion with real cgo.

Patch Set 1 #

Patch Set 2 : code review 1868047: runtime: fix goc2c for rename to goc2c and *.goc #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/pkg/runtime/goc2c.c	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

peterGo

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

13 years, 9 months ago (2010-07-26 22:58:09 UTC) #1

rsc

13 years, 9 months ago (2010-07-26 23:21:30 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=3fc9f0faf3ff ***

runtime: fix goc2c for rename to goc2c and *.goc

Release 2010-04-27. runtime: rename cgo2c, *.cgo to goc2c, *.goc
to avoid confusion with real cgo.

R=rsc
CC=golang-dev
http://codereview.appspot.com/1868047

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages