Issue 186440043: Backport to es53 branch: 5701,5702,5703,5704,5705,5706

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 186440043: Backport to es53 branch: 5701,5702,5703,5704,5705,5706 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 4 months ago by kpreid_google

Modified:
9 years, 4 months ago

Reviewers:
ihab.awad

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/branches/es53/

Visibility:
Public.

More Reviews

Description

All changes since the previous merge. The merge command was: svn merge -c 5701,5702,5703,5704,5705,5706 ^/trunk and there were several conflicts; omitting ones which were trivial (modified code that doesn't exist on this branch, etc.), there were: * MainBrowserTest has new commentary and timeout on guest-scan-* being slow. * test-scan-guest.js's handling of [[ThrowTypeError]] is now completely different between es5 and es53 modes. @r5707

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+360 lines, -88 lines)			Patch
M	.	View	0 chunks	+0 lines, -0 lines	0 comments	Download
M	src/com/google/caja/plugin/csslexer.js	View	1 chunk	+12 lines, -3 lines	0 comments	Download
M	src/com/google/caja/plugin/domado.js	View	8 chunks	+111 lines, -41 lines	0 comments	Download
M	src/com/google/caja/plugin/html-emitter.js	View	2 chunks	+16 lines, -18 lines	0 comments	Download
M	src/com/google/caja/plugin/ses-frame-group.js	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	src/com/google/caja/ses/repairES5.js	View	11 chunks	+104 lines, -2 lines	0 comments	Download
M	src/com/google/caja/ses/startSES.js	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	tests/com/google/caja/plugin/MainBrowserTest.java	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	tests/com/google/caja/plugin/jsunit.js	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/com/google/caja/plugin/test-cajajs-invocation.js	View	1 chunk	+35 lines, -0 lines	0 comments	Download
MM	tests/com/google/caja/plugin/test-domado-events-guest.html	View	5 chunks	+47 lines, -9 lines	0 comments	Download
M	tests/com/google/caja/plugin/test-scan-guest.js	View	1 chunk	+11 lines, -6 lines	0 comments	Download
M	tests/com/google/caja/plugin/test-taming-tamed-guest.html	View	1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

lgtm

Expand All Messages | Collapse All Messages