Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(52)

Issue 186420043: TBR: i#1566 software divide on ARM: use libgcc divide emulation code

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by bruening
Modified:
11 years, 6 months ago
Reviewers:
zhaoqin
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#1566 software divide on ARM: use libgcc divide emulation code Adds gcc runtime code under third_party/libgcc to supply software divide emulation for ARM, where we can't rely on hardware integer divide support. The GPL "GCC Runtime Library Exception" allows us to link these files into our BSD library. Imports 4 assembly files and 1 extracted C routine from libgcc. The assembly files are built in separate passes due to label conflicts. Fixes #1566 ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4916 lines, -21 lines) Patch
M core/CMakeLists.txt View 1 chunk +25 lines, -1 line 0 comments Download
M core/unix/os.c View 2 chunks +5 lines, -8 lines 0 comments Download
A third_party/libgcc/COPYING.RUNTIME View 1 chunk +72 lines, -0 lines 0 comments Download
A + third_party/libgcc/COPYING3 View 2 chunks +0 lines, -12 lines 0 comments Download
A third_party/libgcc/README.dynamorio View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/libgcc/arm/bpabi.S View 1 chunk +257 lines, -0 lines 0 comments Download
A third_party/libgcc/arm/ieee754-df.S View 1 chunk +1406 lines, -0 lines 0 comments Download
A third_party/libgcc/arm/ieee754-sf.S View 1 chunk +1033 lines, -0 lines 0 comments Download
A third_party/libgcc/arm/lib1funcs.S View 1 chunk +1990 lines, -0 lines 0 comments Download
A third_party/libgcc/udivmoddi4.c View 1 chunk +90 lines, -0 lines 0 comments Download

Messages

Total messages: 2
bruening
11 years, 6 months ago (2014-12-16 05:39:37 UTC) #1
bruening
11 years, 6 months ago (2014-12-16 05:39:46 UTC) #2
Committed as
https://github.com/DynamoRIO/dynamorio/commit/bff4759bf5d9cc7c7c9a832f0cdfcd3...

Final commit log: 
---------------
i#1566 software divide on ARM: use libgcc divide emulation code

Adds gcc runtime code under third_party/libgcc to supply software divide
emulation for ARM, where we can't rely on hardware integer divide support.
The GPL "GCC Runtime Library Exception" allows us to link these files into
our BSD library.

Imports 4 assembly files and 1 extracted C routine from libgcc.  The
assembly files are built in separate passes due to label conflicts.

Fixes #1566

Review-URL: https://codereview.appspot.com/186420043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b