Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14853)

Issue 1864041: Eval and unresolved variables in chapter 7 tests.

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 9 months ago by pedro.delgallego
Modified:
13 years, 8 months ago
CC:
pedro.delgallego
Base URL:
http://sputniktests.googlecode.com/svn/trunk
Visibility:
Public.

Description

In chapter 7, there are tests that use eval to introduce variables into the scope. In Strict mode, eval cannot introduce variables, so is necessary to set up the variables out of the eval. There are also some unresolved variablesin the tests, unresolved variables lead to an error in Strict Mode.

Patch Set 1 #

Patch Set 2 : section 7.3 #

Patch Set 3 : Section 7.5 #

Patch Set 4 : Section 7.6 #

Patch Set 5 : section 7.87 #

Patch Set 6 : Section 7.8 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -40 lines) Patch
7.8.4_String_Literals/S7.8.4_A2.1_T1.js View 1 chunk +3 lines, -3 lines 0 comments Download
7.8.4_String_Literals/S7.8.4_A2.1_T2.js View 1 chunk +3 lines, -3 lines 0 comments Download
7.8.4_String_Literals/S7.8.4_A2.2_T1.js View 1 chunk +3 lines, -3 lines 0 comments Download
7.8.4_String_Literals/S7.8.4_A2.2_T2.js View 1 chunk +3 lines, -3 lines 0 comments Download
7.8.4_String_Literals/S7.8.4_A2.3_T1.js View 1 chunk +3 lines, -3 lines 0 comments Download
7.8.4_String_Literals/S7.8.4_A4.2_T1.js View 1 chunk +3 lines, -3 lines 0 comments Download
7.8.4_String_Literals/S7.8.4_A4.2_T3.js View 1 chunk +3 lines, -3 lines 0 comments Download
7.8.4_String_Literals/S7.8.4_A4.2_T5.js View 1 chunk +3 lines, -3 lines 0 comments Download
7.8.4_String_Literals/S7.8.4_A4.2_T7.js View 1 chunk +3 lines, -3 lines 0 comments Download
7.8.4_String_Literals/S7.8.4_A6.1_T2.js View 1 chunk +3 lines, -3 lines 0 comments Download
7.8.4_String_Literals/S7.8.4_A6.1_T3.js View 1 chunk +3 lines, -3 lines 0 comments Download
7.8.4_String_Literals/S7.8.4_A7.1_T2.js View 1 chunk +3 lines, -3 lines 0 comments Download
7.8.4_String_Literals/S7.8.4_A7.1_T3.js View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8
pedro.delgallego
13 years, 9 months ago (2010-07-16 12:32:54 UTC) #1
pedro.delgallego
section 7.3
13 years, 9 months ago (2010-07-16 12:33:39 UTC) #2
pedro.delgallego
Section 7.5
13 years, 9 months ago (2010-07-16 12:35:03 UTC) #3
pedro.delgallego
Section 7.6
13 years, 9 months ago (2010-07-16 12:35:35 UTC) #4
pedro.delgallego
section 7.87
13 years, 9 months ago (2010-07-16 12:36:15 UTC) #5
pedro.delgallego
Section 7.8
13 years, 9 months ago (2010-07-16 12:36:32 UTC) #6
christian.plesner.hansen
How have you tested this? > S7.6_A1.2_T3.js: > if ( eval($ + '!==' + \u0024) ...
13 years, 8 months ago (2010-08-08 02:38:00 UTC) #7
christian.plesner.hansen
13 years, 8 months ago (2010-08-08 02:39:49 UTC) #8
Also, remember to publish+mail when uploading a CL or making changes, otherwise
your reviewers won't notice.  I didn't receive an email for some of these CLs,
including this one.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b