Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1739)

Issue 18630045: Add Deploy tab to bundle details view

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by jeff.pihach
Modified:
10 years, 6 months ago
Reviewers:
bac, mp+193135
Visibility:
Public.

Description

Add Deploy tab to bundle details view Also adds: bundle location into bundle details view header bzr branch command to Code tab moved the Readme tab to the second tab spot as per UX https://code.launchpad.net/~hatch/juju-gui/bundle-id/+merge/193135 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 13

Patch Set 2 : Add Deploy tab to bundle details view #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -3 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/templates/bundle.handlebars View 1 4 chunks +29 lines, -3 lines 0 comments Download

Messages

Total messages: 4
jeff.pihach
Please take a look.
10 years, 6 months ago (2013-10-29 20:41:31 UTC) #1
bac
LGTM with changes. Thanks! https://codereview.appspot.com/18630045/diff/1/app/templates/bundle.handlebars File app/templates/bundle.handlebars (left): https://codereview.appspot.com/18630045/diff/1/app/templates/bundle.handlebars#oldcode162 app/templates/bundle.handlebars:162: Wow, I know you didn't ...
10 years, 6 months ago (2013-10-29 21:12:52 UTC) #2
jeff.pihach
Changes made, thank you for the review! https://codereview.appspot.com/18630045/diff/1/app/templates/bundle.handlebars File app/templates/bundle.handlebars (left): https://codereview.appspot.com/18630045/diff/1/app/templates/bundle.handlebars#oldcode162 app/templates/bundle.handlebars:162: On 2013/10/29 ...
10 years, 6 months ago (2013-10-29 21:20:58 UTC) #3
jeff.pihach
10 years, 6 months ago (2013-10-29 21:27:07 UTC) #4
*** Submitted:

Add Deploy tab to bundle details view

Also adds:
bundle location into bundle details view header
bzr branch command to Code tab
moved the Readme tab to the second tab spot as per UX

R=bac
CC=
https://codereview.appspot.com/18630045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b