Issue 1862052: Add support to domita.js for myDomElement.style.cssText = '...';

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1862052: Add support to domita.js for myDomElement.style.cssText = '...'; (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 10 months ago by MikeSamuel

Modified:
15 years, 10 months ago

Reviewers:
Jasvir

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

http://code.google.com/p/google-caja/issues/detail?id=1161 This hooks cssparser into domita.js and adds cssparser.js into the compiled JS bundles. Submitted @4240

Patch Set 2 : Add support to domita.js for myDomElement.style.cssText = '...'; #

Total comments: 4

Patch Set 3 : Add support to domita.js for myDomElement.style.cssText = '...'; #

Created: 15 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -15 lines)			Patch
M	build.xml	View	1 2	7 chunks	+7 lines, -0 lines	0 comments	Download
M	src/com/google/caja/plugin/domita.js	View	1 2	5 chunks	+29 lines, -15 lines	0 comments	Download
M	tests/com/google/caja/plugin/domita_test.html	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/com/google/caja/plugin/domita_test_untrusted.html	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Jasvir

LGTM http://codereview.appspot.com/1862052/diff/3001/4003 File src/com/google/caja/plugin/domita.js (right): http://codereview.appspot.com/1862052/diff/3001/4003#newcode3619 src/com/google/caja/plugin/domita.js:3619: /** http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-CSSStyleDeclaration */ wrap http://codereview.appspot.com/1862052/diff/3001/4002 File tests/com/google/caja/plugin/domita_test_untrusted.html (right): ...

15 years, 10 months ago (2010-08-10 21:29:41 UTC) #3

MikeSamuel

15 years, 10 months ago (2010-08-11 04:38:07 UTC) #4

http://codereview.appspot.com/1862052/diff/3001/4003
File src/com/google/caja/plugin/domita.js (right):

http://codereview.appspot.com/1862052/diff/3001/4003#newcode3619
src/com/google/caja/plugin/domita.js:3619: /**
http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-CSSStyleDeclaration */
On 2010/08/10 21:29:41, jasvir wrote:
> wrap

Done.

http://codereview.appspot.com/1862052/diff/3001/4002
File tests/com/google/caja/plugin/domita_test_untrusted.html (right):

http://codereview.appspot.com/1862052/diff/3001/4002#newcode2360
tests/com/google/caja/plugin/domita_test_untrusted.html:2360:
assertEquals('wait', cursor(el));
On 2010/08/10 21:29:41, jasvir wrote:
> Can we add a test case for el.style.cssText = 'cssText: "cursor:wait"' and
> ensure that this fails.  I suspect this does since cssText is not whitelisted
> but I'd like to ensure that css whitelists can't be worked around using
aliases
> that group css properties like this one. 

Done.

Expand All Messages | Collapse All Messages