Implements inlining expansion in Optimizer.

Implements inlining expansion in Optimizer.

R=chrisha@chromium.org, sebmarchand@chromium.org

Committed: https://code.google.com/p/sawbuck/source/detail?r=1868

[etienneb, 2013-10-30 17:58:42]

PTAL.

[chrisha, 2013-10-30 19:40:23]

A handful of nits, but otherwise lgtm!

https://codereview.appspot.com/18520043/diff/100001/syzygy/optimize/transform...
File syzygy/optimize/transforms/inlining_transform.cc (right):

https://codereview.appspot.com/18520043/diff/100001/syzygy/optimize/transform...
syzygy/optimize/transforms/inlining_transform.cc:82: // Trivial body only have
one basic block.
only has*

https://codereview.appspot.com/18520043/diff/100001/syzygy/optimize/transform...
syzygy/optimize/transforms/inlining_transform.cc:91: // Iterates through each
instructions.
each instruction*.

https://codereview.appspot.com/18520043/diff/100001/syzygy/optimize/transform...
syzygy/optimize/transforms/inlining_transform.cc:131: // The basic block must
has a return (to remove the caller address on stack)
must have*

https://codereview.appspot.com/18520043/diff/100001/syzygy/optimize/transform...
syzygy/optimize/transforms/inlining_transform.cc:161: // Iterates through each
instructions.
each instruction*.

https://codereview.appspot.com/18520043/diff/100001/syzygy/optimize/transform...
syzygy/optimize/transforms/inlining_transform.cc:199: if
(!policy->CodeBlockAttributesAreBasicBlockSafe(caller))
Need to use 'CodeBlockIsSafeToBasicBlockDecompose' (this is what made
SampleGrinder blow up on Chrome)

https://codereview.appspot.com/18520043/diff/100001/syzygy/optimize/transform...
syzygy/optimize/transforms/inlining_transform.cc:202: // Iterates through each
basic blocks.
each basic block*.

https://codereview.appspot.com/18520043/diff/100001/syzygy/optimize/transform...
syzygy/optimize/transforms/inlining_transform.cc:210: // Iterates through each
instructions.
each instruction*.

https://codereview.appspot.com/18520043/diff/100001/syzygy/optimize/transform...
syzygy/optimize/transforms/inlining_transform.cc:226:
!policy->CodeBlockIsSafeToBasicBlockDecompose(callee)) {
Don't need to apply both.... IsSafeToBasicBlockDecompose subsumes
AttributesAreBasicBlockSafe.

[etienneb, 2013-10-30 19:47:37]

done.
Seb? Otherwise, I'm committing soon.

https://codereview.appspot.com/18520043/diff/100001/syzygy/optimize/transform...
File syzygy/optimize/transforms/inlining_transform.cc (right):

https://codereview.appspot.com/18520043/diff/100001/syzygy/optimize/transform...
syzygy/optimize/transforms/inlining_transform.cc:82: // Trivial body only have
one basic block.
On 2013/10/30 19:40:23, chrisha wrote:
> only has*

Done.

https://codereview.appspot.com/18520043/diff/100001/syzygy/optimize/transform...
syzygy/optimize/transforms/inlining_transform.cc:91: // Iterates through each
instructions.
On 2013/10/30 19:40:23, chrisha wrote:
> each instruction*.

Done.

https://codereview.appspot.com/18520043/diff/100001/syzygy/optimize/transform...
syzygy/optimize/transforms/inlining_transform.cc:131: // The basic block must
has a return (to remove the caller address on stack)
On 2013/10/30 19:40:23, chrisha wrote:
> must have*

Done.

https://codereview.appspot.com/18520043/diff/100001/syzygy/optimize/transform...
syzygy/optimize/transforms/inlining_transform.cc:161: // Iterates through each
instructions.
On 2013/10/30 19:40:23, chrisha wrote:
> each instruction*.

Done.

https://codereview.appspot.com/18520043/diff/100001/syzygy/optimize/transform...
syzygy/optimize/transforms/inlining_transform.cc:199: if
(!policy->CodeBlockAttributesAreBasicBlockSafe(caller))
On 2013/10/30 19:40:23, chrisha wrote:
> Need to use 'CodeBlockIsSafeToBasicBlockDecompose' (this is what made
> SampleGrinder blow up on Chrome)

Done.

https://codereview.appspot.com/18520043/diff/100001/syzygy/optimize/transform...
syzygy/optimize/transforms/inlining_transform.cc:202: // Iterates through each
basic blocks.
On 2013/10/30 19:40:23, chrisha wrote:
> each basic block*.

Done.

https://codereview.appspot.com/18520043/diff/100001/syzygy/optimize/transform...
syzygy/optimize/transforms/inlining_transform.cc:210: // Iterates through each
instructions.
On 2013/10/30 19:40:23, chrisha wrote:
> each instruction*.

Done.

https://codereview.appspot.com/18520043/diff/100001/syzygy/optimize/transform...
syzygy/optimize/transforms/inlining_transform.cc:226:
!policy->CodeBlockIsSafeToBasicBlockDecompose(callee)) {
On 2013/10/30 19:40:23, chrisha wrote:
> Don't need to apply both.... IsSafeToBasicBlockDecompose subsumes
> AttributesAreBasicBlockSafe.

Done.

[Sébastien Marchand, 2013-10-30 19:52:41]

lgtm ! Nice !

https://codereview.appspot.com/18520043/diff/70006/syzygy/optimize/transforms...
File syzygy/optimize/transforms/inlining_transform.cc (right):

https://codereview.appspot.com/18520043/diff/70006/syzygy/optimize/transforms...
syzygy/optimize/transforms/inlining_transform.cc:56: bool MatchDirectCall(const
Instruction& instr, BlockGraph::Block** callee) {
Comment ?

https://codereview.appspot.com/18520043/diff/70006/syzygy/optimize/transforms...
syzygy/optimize/transforms/inlining_transform.cc:78: bool MatchTrivialBody(const
BasicBlockSubGraph& subgraph,
Ditto.

[etienneb, 2013-10-30 20:11:49]

thank, committing.

[etienneb, 2013-10-30 20:12:48]

Committed patchset #5 manually as r1868 (presubmit successful).