Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1125)

Issue 185140043: Docs: state that LilyPond input is in terms of pitches

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 4 months ago by Keith
Modified:
9 years, 4 months ago
Reviewers:
pkx166h, dak, Trevor Daniels
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Docs: state that LilyPond input is in terms of pitches

Patch Set 1 #

Patch Set 2 : simpler sequence #

Total comments: 6

Patch Set 3 : node name 'Pitch alterations' #

Total comments: 1

Patch Set 4 : \key, and reordering allows shorter text #

Patch Set 5 : make doc got as far as pdf output #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -43 lines) Patch
M Documentation/learning/common-notation.itely View 6 chunks +31 lines, -35 lines 0 comments Download
M Documentation/notation/pitches.itely View 3 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 5
Keith
https://codereview.appspot.com/185140043/diff/20001/Documentation/learning/common-notation.itely File Documentation/learning/common-notation.itely (left): https://codereview.appspot.com/185140043/diff/20001/Documentation/learning/common-notation.itely#oldcode108 Documentation/learning/common-notation.itely:108: @subsection Accidentals and key signatures This section doesn't tell ...
9 years, 4 months ago (2014-12-07 06:41:31 UTC) #1
pkx166h
Fails make. https://codereview.appspot.com/185140043/diff/20001/Documentation/learning/common-notation.itely File Documentation/learning/common-notation.itely (right): https://codereview.appspot.com/185140043/diff/20001/Documentation/learning/common-notation.itely#newcode119 Documentation/learning/common-notation.itely:119: @node Pitches Problem with calling this node ...
9 years, 4 months ago (2014-12-09 07:52:27 UTC) #2
dak
https://codereview.appspot.com/185140043/diff/20001/Documentation/learning/common-notation.itely File Documentation/learning/common-notation.itely (right): https://codereview.appspot.com/185140043/diff/20001/Documentation/learning/common-notation.itely#newcode119 Documentation/learning/common-notation.itely:119: @node Pitches On 2014/12/09 07:52:26, J_lowe wrote: > Problem ...
9 years, 4 months ago (2014-12-09 09:18:08 UTC) #3
Trevor Daniels
Apart from the node name, LGTM. https://codereview.appspot.com/185140043/diff/20001/Documentation/learning/common-notation.itely File Documentation/learning/common-notation.itely (right): https://codereview.appspot.com/185140043/diff/20001/Documentation/learning/common-notation.itely#newcode111 Documentation/learning/common-notation.itely:111: * Pitches:: The ...
9 years, 4 months ago (2014-12-09 09:25:00 UTC) #4
pkx166h
9 years, 4 months ago (2014-12-12 11:28:39 UTC) #5
https://codereview.appspot.com/185140043/diff/40001/Documentation/learning/co...
File Documentation/learning/common-notation.itely (right):

https://codereview.appspot.com/185140043/diff/40001/Documentation/learning/co...
Documentation/learning/common-notation.itely:184: \bar "||" key c \minor
\key not key.

This breaks make doc
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b