Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4874)

Issue 185041: [SHINDIG-1259] Added ability to control what "cache forever" means

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 3 months ago by Jon Weygandt
Modified:
14 years, 3 months ago
Reviewers:
Paul Lindner, shindig.remailer
Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/
Visibility:
Public.

Description

In HttpUtil, when asked to cache a resource forever, the actual duration is 1 year. Modified the class to allow changes to the time. Typically this would be done early on in the system start up phase.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
java/common/src/main/java/org/apache/shindig/common/servlet/HttpUtil.java View 2 chunks +9 lines, -1 line 0 comments Download
java/common/src/test/java/org/apache/shindig/common/servlet/HttpUtilTest.java View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2
Jon Weygandt
14 years, 3 months ago (2010-01-08 20:46:45 UTC) #1
Paul Lindner
14 years, 3 months ago (2010-01-08 22:01:59 UTC) #2
seems fine.  Stylistically I'd prefer DefaultTtl to DEFAULT_TTL since this
member is no longer a constant.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b