code review 185040044: runtime: generate windows callback list with go generate

runtime: generate windows callback list with go generate

This is the last system-dependent file written by cmd/dist.
They are all now written by go generate.

cmd/dist is not needed to start building package runtime
for a different system anymore.

Now all the generated files can be assumed generated, so
delete the clumsy hacks in cmd/api.

Re-enable api check in run.bash.

[rsc, 2014-12-05 18:20:06]

Hello bradfitz (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2014-12-05 18:47:28]

LGTM

Yay deletes.

So we don't check in zcallback_windows.go? When in the process does go generate
run to build that?

[rsc, 2014-12-05 18:51:52]

On Fri, Dec 5, 2014 at 1:47 PM, <bradfitz@golang.org> wrote:

> LGTM
>
> Yay deletes.
>
> So we don't check in zcallback_windows.go? When in the process does go
> generate run to build that?
>

No, we do. Missed hg add I guess.

[rsc, 2014-12-05 19:18:33]

Actually cmd/dist removed it. Made it less aggressive.

[rsc, 2014-12-05 21:24:25]

*** Submitted as https://code.google.com/p/go/source/detail?r=5b665926e5b4 ***

runtime: generate windows callback list with go generate

This is the last system-dependent file written by cmd/dist.
They are all now written by go generate.

cmd/dist is not needed to start building package runtime
for a different system anymore.

Now all the generated files can be assumed generated, so
delete the clumsy hacks in cmd/api.

Re-enable api check in run.bash.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews
https://codereview.appspot.com/185040044

[brainman, 2014-12-05 21:28:01]

https://codereview.appspot.com/185040044/diff/60001/src/runtime/wincallback.go
File src/runtime/wincallback.go (right):

https://codereview.appspot.com/185040044/diff/60001/src/runtime/wincallback.g...
src/runtime/wincallback.go:42: }
Please, generate runtime2_windows.go here too. So we have maxCallback defined in
single place.

Thank you.

Alex

[gobot, 2014-12-05 23:19:46]

This CL appears to have broken the darwin-amd64-race-cheney builder.
See http://build.golang.org/log/e14ae729a5300357b14af809f1b0445487241cea

[brainman, 2014-12-06 04:01:19]

On 2014/12/05 21:28:01, brainman wrote:
> Please, generate runtime2_windows.go here too. So we have maxCallback defined
in
> single place.

Here https://codereview.appspot.com/180640043/ it is.

Alex