Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10665)

Issue 1848054: Adding common WebDriver interface for python bindings

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 9 months ago by jleyba
Modified:
13 years, 9 months ago
Reviewers:
simonstewart, Eran
CC:
webdriver-eng_google.com
Base URL:
http://selenium.googlecode.com/svn/trunk/
Visibility:
Public.

Description

The python bindings for the various drivers do not share a common interface, so it's hard to tell from a glance which driver implements what, or if they even use the same name for each function. This CL defines a common interface for the WebDriver and WebElement classes to help fix this. I've also copied over documentation from javadoc so we can generate pydoc files for our oft-neglected python users.

Patch Set 1 #

Patch Set 2 : Responding to code review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+782 lines, -10 lines) Patch
A common/src/py/webdriver.py View 1 1 chunk +764 lines, -0 lines 0 comments Download
M jobbie/src/py/webdriver.py View 3 chunks +5 lines, -2 lines 0 comments Download
M remote/client/src/py/webdriver.py View 1 chunk +3 lines, -1 line 0 comments Download
M remote/client/src/py/webelement.py View 1 chunk +3 lines, -1 line 0 comments Download
M remote/client/test/py/test_remote_api.py View 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 3
jleyba
13 years, 9 months ago (2010-08-02 16:16:33 UTC) #1
simonstewart
LGTM. I like the fact that there's no distinction between webelement and renderedwebelement, though I'd ...
13 years, 9 months ago (2010-08-03 13:47:15 UTC) #2
jleyba
13 years, 9 months ago (2010-08-03 17:17:11 UTC) #3
Done.

On 2010/08/03 13:47:15, simonstewart wrote:
> LGTM. I like the fact that there's no distinction between webelement and
> renderedwebelement, though I'd be tempted to move the drag and drop methods
off
> there until some asks for them --- they're not quite in the right place.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b