Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(16117)

Issue 183860043: Use std::string instead of string

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by halton
Modified:
9 years, 4 months ago
Reviewers:
wan, sbenza, kosak
CC:
googlemock_googlegroups.com
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M include/gmock/gmock-generated-function-mockers.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6
halton
9 years, 5 months ago (2014-11-28 08:34:51 UTC) #1
halton
This CL is dependency of https://codereview.chromium.org/763833003/
9 years, 5 months ago (2014-11-28 16:08:30 UTC) #2
halton
kosak, wan, could you review?
9 years, 4 months ago (2014-12-02 03:36:57 UTC) #3
wan
+Sam Corey and I are no longer actively involved with this project. I'll let Sam ...
9 years, 4 months ago (2014-12-02 03:41:15 UTC) #4
sbenza
On 2014/11/28 16:08:30, halton wrote: > This CL is dependency of https://codereview.chromium.org/763833003/ From what I ...
9 years, 4 months ago (2014-12-02 14:53:51 UTC) #5
halton
9 years, 4 months ago (2014-12-03 06:56:16 UTC) #6
On 2014/12/02 14:53:51, sbenza wrote:
> On 2014/11/28 16:08:30, halton wrote:
> > This CL is dependency of https://codereview.chromium.org/763833003/
> 
> From what I can see, this is just changing comments. I fail to see how you
> depend on this change for your change.
> I am not opposed to the changes. I just want to understand the reason for
them.

I remembered there is compiler error on this file when work on CL
https://codereview.chromium.org/763833003/.
But after I do a clean build again, this change is not needed at all. Being that
said, this CL is not required.
But from my point of view, the commented example code is better to change as
std::. 

Anyway, it is your call to accept this CL or not.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b