+Sam Corey and I are no longer actively involved with this project. I'll let Sam ...
9 years, 4 months ago
(2014-12-02 03:41:15 UTC)
#4
+Sam
Corey and I are no longer actively involved with this project. I'll let
Sam respond. Thanks,
On Mon, Dec 1, 2014 at 7:36 PM, <halton.huo@intel.com> wrote:
> kosak, wan, could you review?
>
> https://codereview.appspot.com/183860043/
>
--
Zhanyong
On 2014/11/28 16:08:30, halton wrote: > This CL is dependency of https://codereview.chromium.org/763833003/ From what I ...
9 years, 4 months ago
(2014-12-02 14:53:51 UTC)
#5
On 2014/11/28 16:08:30, halton wrote:
> This CL is dependency of https://codereview.chromium.org/763833003/
From what I can see, this is just changing comments. I fail to see how you
depend on this change for your change.
I am not opposed to the changes. I just want to understand the reason for them.
On 2014/12/02 14:53:51, sbenza wrote: > On 2014/11/28 16:08:30, halton wrote: > > This CL ...
9 years, 4 months ago
(2014-12-03 06:56:16 UTC)
#6
On 2014/12/02 14:53:51, sbenza wrote:
> On 2014/11/28 16:08:30, halton wrote:
> > This CL is dependency of https://codereview.chromium.org/763833003/
>
> From what I can see, this is just changing comments. I fail to see how you
> depend on this change for your change.
> I am not opposed to the changes. I just want to understand the reason for
them.
I remembered there is compiler error on this file when work on CL
https://codereview.chromium.org/763833003/.
But after I do a clean build again, this change is not needed at all. Being that
said, this CL is not required.
But from my point of view, the commented example code is better to change as
std::.
Anyway, it is your call to accept this CL or not.
Issue 183860043: Use std::string instead of string
Created 9 years, 5 months ago by halton
Modified 9 years, 4 months ago
Reviewers: kosak, wan, sbenza
Base URL:
Comments: 0