Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(898)

Issue 18370043: code review 18370043: freetype: fix MDRP/MIRP Set-RP0 bit and fix normalize r... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by nigeltao
Modified:
11 years, 1 month ago
Reviewers:
bsiegert
CC:
bsiegert, golang-dev, remyoudompheng
Visibility:
Public.

Description

freetype: fix MDRP/MIRP Set-RP0 bit and fix normalize rounding. Also make phantom point delta-X adjustment. Also make print-glyph-points require Freetype version >= 2.5, which is the latest version, at the time of writing.

Patch Set 1 #

Patch Set 2 : diff -r 179bcc829dd5 https://code.google.com/p/freetype-go #

Patch Set 3 : diff -r 179bcc829dd5 https://code.google.com/p/freetype-go #

Total comments: 5

Patch Set 4 : diff -r 179bcc829dd5 https://code.google.com/p/freetype-go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -19 lines) Patch
M cmd/print-glyph-points/main.c View 1 2 3 4 chunks +16 lines, -8 lines 0 comments Download
M freetype/truetype/glyph.go View 1 1 chunk +5 lines, -0 lines 0 comments Download
M freetype/truetype/hint.go View 1 3 chunks +17 lines, -10 lines 0 comments Download
M freetype/truetype/hint_test.go View 1 2 3 2 chunks +29 lines, -0 lines 0 comments Download
M freetype/truetype/truetype_test.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
nigeltao
Hello bsiegert@gmail.com (cc: golang-dev@googlegroups.com, remyoudompheng@gmail.com), I'd like you to review this change to https://code.google.com/p/freetype-go
11 years, 1 month ago (2013-10-28 11:30:37 UTC) #1
bsiegert
LGTM modulo comments below https://codereview.appspot.com/18370043/diff/40001/cmd/print-glyph-points/main.c File cmd/print-glyph-points/main.c (right): https://codereview.appspot.com/18370043/diff/40001/cmd/print-glyph-points/main.c#newcode46 cmd/print-glyph-points/main.c:46: if ((major < 2) || ...
11 years, 1 month ago (2013-10-28 11:58:45 UTC) #2
nigeltao
https://codereview.appspot.com/18370043/diff/40001/freetype/truetype/hint_test.go File freetype/truetype/hint_test.go (right): https://codereview.appspot.com/18370043/diff/40001/freetype/truetype/hint_test.go#newcode669 freetype/truetype/hint_test.go:669: t.Errorf("i=%d: got %v, want %v", i, got, want) On ...
11 years, 1 month ago (2013-10-29 09:58:30 UTC) #3
nigeltao
11 years, 1 month ago (2013-10-29 09:59:51 UTC) #4
*** Submitted as
https://code.google.com/p/freetype-go/source/detail?r=612c90e07c14 ***

freetype: fix MDRP/MIRP Set-RP0 bit and fix normalize rounding.

Also make phantom point delta-X adjustment.

Also make print-glyph-points require Freetype version >= 2.5, which is
the latest version, at the time of writing.

R=bsiegert
CC=golang-dev, remyoudompheng
https://codereview.appspot.com/18370043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b