code review 18370043: freetype: fix MDRP/MIRP Set-RP0 bit and fix normalize r...

freetype: fix MDRP/MIRP Set-RP0 bit and fix normalize rounding.

Also make phantom point delta-X adjustment.

Also make print-glyph-points require Freetype version >= 2.5, which is
the latest version, at the time of writing.

[nigeltao, 2013-10-28 11:30:37]

Hello bsiegert@gmail.com (cc: golang-dev@googlegroups.com,
remyoudompheng@gmail.com),

I'd like you to review this change to
https://code.google.com/p/freetype-go

[bsiegert, 2013-10-28 11:58:45]

LGTM modulo comments below

https://codereview.appspot.com/18370043/diff/40001/cmd/print-glyph-points/main.c
File cmd/print-glyph-points/main.c (right):

https://codereview.appspot.com/18370043/diff/40001/cmd/print-glyph-points/mai...
cmd/print-glyph-points/main.c:46: if ((major < 2) || (minor < 5)) {
if ((major < 2) || (major == 2 && minor < 5)) {

Otherwise this would fail with a hypothetical 3.0.

https://codereview.appspot.com/18370043/diff/40001/freetype/truetype/hint_tes...
File freetype/truetype/hint_test.go (right):

https://codereview.appspot.com/18370043/diff/40001/freetype/truetype/hint_tes...
freetype/truetype/hint_test.go:586: // TestMove tests that the Hinter.move
method matches the C Freetype's output.
matches the output of the C Freetype.

https://codereview.appspot.com/18370043/diff/40001/freetype/truetype/hint_tes...
freetype/truetype/hint_test.go:647: // TestNormalize tests that the normalize
function matches the C Freetype's
the output of the C Freetype.

https://codereview.appspot.com/18370043/diff/40001/freetype/truetype/hint_tes...
freetype/truetype/hint_test.go:669: t.Errorf("i=%d: got %v, want %v", i, got,
want)
mention normalize in the error string?

[nigeltao, 2013-10-29 09:58:30]

https://codereview.appspot.com/18370043/diff/40001/freetype/truetype/hint_tes...
File freetype/truetype/hint_test.go (right):

https://codereview.appspot.com/18370043/diff/40001/freetype/truetype/hint_tes...
freetype/truetype/hint_test.go:669: t.Errorf("i=%d: got %v, want %v", i, got,
want)
On 2013/10/28 11:58:45, bsiegert wrote:
> mention normalize in the error string?

There's no need. Any failures will be printed under a "TestNormalize" heading.

[nigeltao, 2013-10-29 09:59:51]

*** Submitted as
https://code.google.com/p/freetype-go/source/detail?r=612c90e07c14 ***

freetype: fix MDRP/MIRP Set-RP0 bit and fix normalize rounding.

Also make phantom point delta-X adjustment.

Also make print-glyph-points require Freetype version >= 2.5, which is
the latest version, at the time of writing.

R=bsiegert
CC=golang-dev, remyoudompheng
https://codereview.appspot.com/18370043