Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(22)

Issue 183500043: code review 183500043: compiler: Don't built hash/equality functions for thunk... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by iant
Modified:
9 years, 8 months ago
Reviewers:
CC:
iant, gofrontend-dev_googlegroups.com
Visibility:
Public.

Description

compiler: Don't built hash/equality functions for thunk structs. They are never necessary, and they can cause problems when a thunk is used to pass an unexported type from a different package to a function defined in that package. The resulting struct type may need to call the comparison routine from the other package, which will fail because the type is not exported. This will be bug492 in the master testsuite.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M go/statements.h View 2 chunks +7 lines, -0 lines 0 comments Download
M go/statements.cc View 2 chunks +16 lines, -1 line 0 comments Download
M go/types.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2
iant
Hello iant (cc: gofrontend-dev@googlegroups.com), I'd like you to review this change to https://gofrontend.googlecode.com/hg/
9 years, 8 months ago (2014-12-16 22:50:48 UTC) #1
iant
9 years, 8 months ago (2014-12-16 22:50:53 UTC) #2
*** Submitted as
https://code.google.com/p/gofrontend/source/detail?r=b7c3f882d939 ***

compiler: Don't built hash/equality functions for thunk structs.

They are never necessary, and they can cause problems when a
thunk is used to pass an unexported type from a different
package to a function defined in that package.  The resulting
struct type may need to call the comparison routine from the
other package, which will fail because the type is not
exported.  This will be bug492 in the master testsuite.

R=iant
CC=gofrontend-dev
https://codereview.appspot.com/183500043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b