Issue 183310044: Fix subprocess when using close_fds=False

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 183310044: Fix subprocess when using close_fds=False

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 4 months ago by haypo_gmail

Modified:
9 years, 4 months ago

Reviewers:
yselivanov

Visibility:
Public.

More Reviews

Description

Fix subprocess when using close_fds=False

Patch Set 1 #

Total comments: 1

Patch Set 2 : Cleanup the fcntl import #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -2 lines)			Patch
	M	asyncio/unix_events.py	View	1	4 chunks	+22 lines, -2 lines	0 comments	Download
	M	tests/test_subprocess.py	View		1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

yselivanov

9 years, 4 months ago (2014-12-11 17:19:23 UTC) #1

I like this patch.

https://codereview.appspot.com/183310044/diff/1/asyncio/unix_events.py
File asyncio/unix_events.py (right):

https://codereview.appspot.com/183310044/diff/1/asyncio/unix_events.py#newcod...
asyncio/unix_events.py:556: def _set_inheritable(fd, inheritable):
I'd simply put "import fcntl" above this line.

Expand All Messages | Collapse All Messages