Issue 182730043: i#1648 LsaFreeMemory not found, Windows 8.1

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 182730043: i#1648 LsaFreeMemory not found, Windows 8.1

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 5 months ago by toshi

Modified:
9 years, 5 months ago

Reviewers:
bruening

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Reviewer: bruening@google.com i#1648 LsaFreeMemory not found, Windows 8.1 i#1648 Fixes missing LsaFreeMemory in KernelBase.dll error on Windows 8.1

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	core/win32/loader.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bruening

This should be a 2nd patchset on the original review (# 173560043), to make it ...

9 years, 5 months ago (2014-11-25 03:42:43 UTC) #2

bruening

Also, repeating a prior suggestion: the "Fixes issue 1648" syntax will avoid you needing to ...

9 years, 5 months ago (2014-11-25 03:43:53 UTC) #3

bruening

Please see the prior comments for future reviews about using the same review page with ...

9 years, 5 months ago (2014-11-25 04:03:41 UTC) #4

toshi

9 years, 5 months ago (2014-11-26 20:00:09 UTC) #5

On 2014/11/25 04:03:41, bruening wrote:
> Please see the prior comments for future reviews about using the same review
> page with additional patchsets.  This review LGTM.

Thanks for the response, all the above comments are noted

Expand All Messages | Collapse All Messages