Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(96)

Issue 182580043: code review 182580043: encoding/xml: remove SyntaxError.Byte (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by rsc
Modified:
10 years, 3 months ago
Reviewers:
bradfitz
CC:
bradfitz, golang-codereviews
Visibility:
Public.

Description

encoding/xml: remove SyntaxError.Byte It is unused. It was introduced in the CL that added InputOffset. I suspect it was an editing mistake.

Patch Set 1 #

Patch Set 2 : diff -r 94be5d381354added3f084261ff285c48304fe34 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 94be5d381354added3f084261ff285c48304fe34 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 94be5d381354added3f084261ff285c48304fe34 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/encoding/xml/xml.go View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3
rsc
Hello bradfitz (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
10 years, 3 months ago (2014-12-06 02:31:18 UTC) #1
bradfitz
LGTM On Fri, Dec 5, 2014 at 6:31 PM, <rsc@golang.org> wrote: > Reviewers: bradfitz, > ...
10 years, 3 months ago (2014-12-06 02:32:07 UTC) #2
rsc
10 years, 3 months ago (2014-12-06 02:33:12 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=2d1ab17a670a ***

encoding/xml: remove SyntaxError.Byte

It is unused. It was introduced in the CL that added InputOffset.
I suspect it was an editing mistake.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews
https://codereview.appspot.com/182580043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b