Issue 182480043: code review 182480043: cmd/go: fix build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 182480043: code review 182480043: cmd/go: fix build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by r

Modified:
10 years, 3 months ago

Reviewers:
adg1

CC:
golang-codereviews, adg1

Visibility:
Public.

Description

cmd/go: fix build The new semantics of split require the newline be present. The test was stale.

Patch Set 2 : diff -r 573a7b5178c42afff86df45bfbe88c8bce8df7c7 https://code.google.com/p/go #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/cmd/go/generate.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/cmd/go/generate_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 3 months ago (2014-12-05 00:27:07 UTC) #1

adg1

LGTM https://codereview.appspot.com/182480043/diff/1/src/cmd/go/generate.go File src/cmd/go/generate.go (right): https://codereview.appspot.com/182480043/diff/1/src/cmd/go/generate.go#newcode253 src/cmd/go/generate.go:253: // The initial //go:generate element is prsent in ...

10 years, 3 months ago (2014-12-05 00:30:54 UTC) #2

10 years, 3 months ago (2014-12-05 00:38:01 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=8d42099cdc23 ***

cmd/go: fix build
The new semantics of split require the newline be present.
The test was stale.

LGTM=adg
R=golang-codereviews, adg
CC=golang-codereviews
https://codereview.appspot.com/182480043

Expand All Messages | Collapse All Messages