code review 18230043: misc/emacs: support godef-jump on import statements

misc/emacs: support godef-jump on import statements

The newest version of godef supports jumping to a package's source
directory if point is on an import statement.

[Dominik Honnef, 2013-10-28 02:15:28]

Hello adonovan@google.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[adonovan, 2013-10-29 15:13:23]

LGTM

https://codereview.appspot.com/18230043/diff/40001/misc/emacs/go-mode.el
File misc/emacs/go-mode.el (right):

https://codereview.appspot.com/18230043/diff/40001/misc/emacs/go-mode.el#newc...
misc/emacs/go-mode.el:954: (funcall (if other-window 'find-file-other-window
'find-file) specifier)
#'find-file-other-window #'find-file

(Emacs Lisp doesn't strictly require sharp-quote for functions because it will
lookup the function value of a symbol during apply.  But Emacs Lisp's optimizer
does exploit them, and I find it easier to read the intention.)

[adonovan, 2013-10-29 15:15:08]

*** Submitted as https://code.google.com/p/go/source/detail?r=f2b59b5163b0 ***

misc/emacs: support godef-jump on import statements

The newest version of godef supports jumping to a package's source
directory if point is on an import statement.

R=adonovan
CC=golang-dev
https://codereview.appspot.com/18230043

Committer: Alan Donovan <adonovan@google.com>

[Dominik Honnef, 2013-10-29 15:16:48]

Haha, darn. I copied that from 4 lines down. I guess you didn't complain last
time ;) 

I'll send a follow-up CL fixing that for all existing symbols.

[adonovan, 2013-10-29 15:17:37]

Don't worry about it; I nailed both of those ones.


On 29 October 2013 11:16, <dominik.honnef@gmail.com> wrote:

> Haha, darn. I copied that from 4 lines down. I guess you didn't complain
> last time ;)
>
> I'll send a follow-up CL fixing that for all existing symbols.
>
>
https://codereview.appspot.**com/18230043/<https://codereview.appspot.com/182...
>