Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(802)

Issue 181770043: code review 181770043: goprotobuf: Use encoding.TextMarshaler and encoding.Tex... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by dsymonds
Modified:
9 years, 6 months ago
Reviewers:
r
CC:
r, golang-codereviews
Visibility:
Public.

Description

goprotobuf: Use encoding.TextMarshaler and encoding.TextUnmarshaler in place of the identical custom interfaces. encoding.Text{Marshaler,Unmarshaler} were added in Go 1.2 (April 2013); it's safe to rely on them now.

Patch Set 1 #

Patch Set 2 : diff -r 7b1a95a08cc267525579d936e6fcbace64ad506f https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r 7b1a95a08cc267525579d936e6fcbace64ad506f https://code.google.com/p/goprotobuf #

Patch Set 4 : diff -r 7b1a95a08cc267525579d936e6fcbace64ad506f https://code.google.com/p/goprotobuf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -18 lines) Patch
M proto/text.go View 1 4 chunks +3 lines, -9 lines 0 comments Download
M proto/text_parser.go View 1 4 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 3
dsymonds
Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf
9 years, 6 months ago (2014-11-20 02:47:42 UTC) #1
r
LGTM
9 years, 6 months ago (2014-11-20 03:30:46 UTC) #2
dsymonds
9 years, 6 months ago (2014-11-20 03:33:48 UTC) #3
*** Submitted as
https://code.google.com/p/goprotobuf/source/detail?r=9c47acdcaa3f ***

goprotobuf: Use encoding.TextMarshaler and encoding.TextUnmarshaler in place of
the identical custom interfaces.

encoding.Text{Marshaler,Unmarshaler} were added in Go 1.2 (April 2013);
it's safe to rely on them now.

LGTM=r
R=r
CC=golang-codereviews
https://codereview.appspot.com/181770043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b