Issue 181100044: [dev.garbage] code review 181100044: all: merge dev.cc (81884b89bd88) into dev.garbage

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 181100044: [dev.garbage] code review 181100044: all: merge dev.cc (81884b89bd88) into dev.garbage (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by rsc

Modified:
10 years, 6 months ago

Reviewers:
gobot

CC:
rlh, golang-codereviews

Visibility:
Public.

Description

all: merge dev.cc (81884b89bd88) into dev.garbage

Patch Set 2 : diff -r 640e39ec202b06bf3295261ad2ca03be1f1f9e5a https://code.google.com/p/go/ #

Patch Set 3 : diff -r 640e39ec202b06bf3295261ad2ca03be1f1f9e5a https://code.google.com/p/go/ #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1450 lines, -153 lines)			Patch
M	.hgtags	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	doc/contrib.html	View	1	1 chunk	+8 lines, -13 lines	0 comments	Download
M	doc/go_spec.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/time/update.bash	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/time/zoneinfo.zip	View	1	Binary file		0 comments	Download
M	src/cmd/5g/reg.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/6g/reg.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/9g/opt.h	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/cmd/9g/peep.c	View	1	3 chunks	+892 lines, -4 lines	0 comments	Download
M	src/cmd/9g/prog.c	View	1	2 chunks	+162 lines, -0 lines	0 comments	Download
M	src/cmd/9g/reg.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/9l/asm.c	View	1	2 chunks	+13 lines, -9 lines	0 comments	Download
M	src/cmd/go/doc.go	View	1	3 chunks	+20 lines, -8 lines	0 comments	Download
M	src/cmd/go/generate.go	View	1	3 chunks	+58 lines, -17 lines	0 comments	Download
M	src/cmd/go/generate_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/ld/lib.c	View	1	2 chunks	+12 lines, -12 lines	0 comments	Download
M	src/cmd/pprof/internal/commands/commands.go	View	1	4 chunks	+22 lines, -4 lines	0 comments	Download
M	src/cmd/pprof/internal/symbolizer/symbolizer.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/go/build/build.go	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download
M	src/go/build/build_test.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/liblink/asm9.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/liblink/pass.c	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/reflect/all_test.go	View	1	1 chunk	+101 lines, -0 lines	0 comments	Download
M	src/reflect/export_test.go	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download
M	src/reflect/type.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/runtime/defs_dragonfly_386.go	View	1	4 chunks	+44 lines, -36 lines	0 comments	Download
M	src/runtime/proc1.go	View	1	1 chunk	+30 lines, -0 lines	0 comments	Download
R	src/runtime/signal_dragonfly_386.h	View	1	1 chunk	+0 lines, -23 lines	0 comments	Download
M	src/runtime/signal_dragonfly_386.go	View	1	1 chunk	+34 lines, -0 lines	0 comments	Download
M	src/runtime/stack1.go	View	1	2 chunks	+2 lines, -12 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello rlh (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.garbage branch ...

10 years, 6 months ago (2014-12-05 16:40:38 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=d84b21b4bb19 *** [dev.garbage] all: merge dev.cc (81884b89bd88) into dev.garbage TBR=rlh CC=golang-codereviews https://codereview.appspot.com/181100044

10 years, 6 months ago (2014-12-05 16:40:44 UTC) #2

gobot

10 years, 6 months ago (2014-12-05 16:51:15 UTC) #3

Message was sent while issue was closed.

This CL appears to have broken the freebsd-386 builder.
See http://build.golang.org/log/2a3d7b4ed5eee2987716e4f9f9044697866c489d

Expand All Messages | Collapse All Messages