Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(474)

Issue 180890043: code review 180890043: compiler: Use the static chain as the closure parameter...

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by Richard Henderson
Modified:
9 years, 5 months ago
Reviewers:
iant, gofrontend-dev
CC:
gofrontend-dev_googlegroups.com
Visibility:
Public.

Description

compiler: Use the static chain as the closure parameter from Go This is not a standalone patch; it only touches the Go front end. Further changes are required for the Go runtime. However, it seems best to submit this for review separately. The gcc generic and gimple support for this feature has been committed to mainline. The accompanying changes to the gcc/go/ (but not gofrontend/) will be (re-)submitted to gcc-patches.

Patch Set 1 #

Patch Set 2 : diff -r 96de84075614dd56f47b185977c51d3da147c6a7 https://code.google.com/p/gofrontend/ #

Patch Set 3 : diff -r 96de84075614dd56f47b185977c51d3da147c6a7 https://code.google.com/p/gofrontend/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -34 lines) Patch
M go/backend.h View 1 2 chunks +6 lines, -1 line 0 comments Download
M go/expressions.cc View 1 4 chunks +8 lines, -13 lines 0 comments Download
M go/gogo.h View 1 2 chunks +14 lines, -0 lines 0 comments Download
M go/gogo.cc View 1 7 chunks +15 lines, -14 lines 0 comments Download
M go/runtime.def View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 2
Richard Henderson
Hello gofrontend-dev@googlegroups.com (cc: gofrontend-dev@googlegroups.com, iant@golang.org), I'd like you to review this change to https://code.google.com/p/gofrontend/
9 years, 5 months ago (2014-11-20 06:40:47 UTC) #1
iant
9 years, 5 months ago (2014-11-21 20:15:41 UTC) #2
LGTM

Thanks.  Probably all the related patches should be committed to GCC trunk
simultaneously.  That is this one, 178990043, and another one for gcc/go, right?
 Have you sent that last one out yet?  I didn't see it but I may not have
searched correctly.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b