code review 180049: 1) Change default gofmt default settings for

1) Change default gofmt default settings for
   parsing and printing to new syntax.

   Use -oldparser to parse the old syntax,
   use -oldprinter to print the old syntax.

2) Change default gofmt formatting settings
   to use tabs for indentation only and to use
   spaces for alignment. This will make the code
   alignment insensitive to an editor's tabwidth.

   Use -spaces=false to use tabs for alignment.

3) Manually changed src/exp/parser/parser_test.go
   so that it doesn't try to parse the parser's
   source files using the old syntax (they have
   new syntax now).

4) gofmt -w src misc test/bench

4th set of files.

[gri, 2009-12-15 22:57:38]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review the following change.

[rsc, 2009-12-15 23:19:04]

LGTM

looked at a random sample.


On Tue, Dec 15, 2009 at 14:57,  <gri@golang.org> wrote:
> Reviewers: rsc,
>
> Message:
> Hello rsc (cc: golang-dev@googlegroups.com),
>
> I'd like you to review the following change.
>
>
> Description:
> 1) Change default gofmt default settings for
>   parsing and printing to new syntax.
>
>   Use -oldparser to parse the old syntax,
>   use -oldprinter to print the old syntax.
>
> 2) Change default gofmt formatting settings
>   to use tabs for indentation only and to use
>   spaces for alignment. This will make the code
>   alignment insensitive to an editor's tabwidth.
>
>   Use -spaces=false to use tabs for alignment.
>
> 3) Manually changed src/exp/parser/parser_test.go
>   so that it doesn't try to parse the parser's
>   source files using the old syntax (they have
>   new syntax now).
>
> 4) gofmt -w src misc
>
> 4th set of files.
>
> Please review this at http://codereview.appspot.com/180049
>
> Affected files:
>  M src/pkg/once/once.go
>  M src/pkg/once/once_test.go
>  M src/pkg/os/dir_darwin.go
>  M src/pkg/os/dir_freebsd.go
>  M src/pkg/os/dir_linux.go
>  M src/pkg/os/dir_nacl.go
>  M src/pkg/os/env.go
>  M src/pkg/os/error.go
>  M src/pkg/os/exec.go
>  M src/pkg/os/file.go
>  M src/pkg/os/getwd.go
>  M src/pkg/os/os_test.go
>  M src/pkg/os/path.go
>  M src/pkg/os/path_test.go
>  M src/pkg/os/proc.go
>  M src/pkg/os/stat_darwin.go
>  M src/pkg/os/stat_freebsd.go
>  M src/pkg/os/stat_linux.go
>  M src/pkg/os/stat_nacl.go
>  M src/pkg/os/sys_darwin.go
>  M src/pkg/os/sys_freebsd.go
>  M src/pkg/os/sys_linux.go
>  M src/pkg/os/sys_nacl.go
>  M src/pkg/os/time.go
>  M src/pkg/os/types.go
>  M src/pkg/patch/apply.go
>  M src/pkg/patch/git.go
>  M src/pkg/patch/patch.go
>  M src/pkg/patch/patch_test.go
>  M src/pkg/patch/textdiff.go
>  M src/pkg/path/path.go
>  M src/pkg/path/path_test.go
>  M src/pkg/rand/exp.go
>  M src/pkg/rand/normal.go
>  M src/pkg/rand/rand.go
>  M src/pkg/rand/rand_test.go
>  M src/pkg/rand/rng.go
>  M src/pkg/reflect/all_test.go
>  M src/pkg/reflect/deepequal.go
>  M src/pkg/reflect/tostring_test.go
>  M src/pkg/reflect/type.go
>  M src/pkg/reflect/value.go
>  M src/pkg/regexp/all_test.go
>  M src/pkg/regexp/regexp.go
>  M src/pkg/rpc/client.go
>  M src/pkg/rpc/debug.go
>  M src/pkg/rpc/server.go
>  M src/pkg/rpc/server_test.go
>  M src/pkg/runtime/type.go
>  M src/pkg/sort/sort.go
>  M src/pkg/sort/sort_test.go
>  M src/pkg/strconv/atof.go
>  M src/pkg/strconv/atof_test.go
>  M src/pkg/strconv/atoi.go
>  M src/pkg/strconv/atoi_test.go
>  M src/pkg/strconv/decimal.go
>  M src/pkg/strconv/decimal_test.go
>  M src/pkg/strconv/fp_test.go
>  M src/pkg/strconv/ftoa.go
>  M src/pkg/strconv/ftoa_test.go
>  M src/pkg/strconv/internal_test.go
>  M src/pkg/strconv/itoa.go
>  M src/pkg/strconv/itoa_test.go
>  M src/pkg/strconv/quote.go
>  M src/pkg/strconv/quote_test.go
>  M src/pkg/strings/reader.go
>  M src/pkg/strings/strings.go
>  M src/pkg/strings/strings_test.go
>  M src/pkg/sync/mutex.go
>  M src/pkg/sync/mutex_test.go
>  M src/pkg/sync/rwmutex.go
>  M src/pkg/sync/rwmutex_test.go
>  M src/pkg/syscall/errstr.go
>  M src/pkg/syscall/exec.go
>  M src/pkg/syscall/syscall.go
>  M src/pkg/syscall/syscall_darwin.go
>  M src/pkg/syscall/syscall_darwin_386.go
>  M src/pkg/syscall/syscall_darwin_amd64.go
>  M src/pkg/syscall/syscall_freebsd.go
>  M src/pkg/syscall/syscall_freebsd_386.go
>  M src/pkg/syscall/syscall_freebsd_amd64.go
>  M src/pkg/syscall/syscall_linux.go
>  M src/pkg/syscall/syscall_linux_386.go
>  M src/pkg/syscall/syscall_linux_amd64.go
>  M src/pkg/syscall/syscall_linux_arm.go
>  M src/pkg/syscall/syscall_nacl.go
>  M src/pkg/syscall/syscall_nacl_386.go
>  M src/pkg/syscall/zerrors_darwin_386.go
>  M src/pkg/syscall/zerrors_darwin_amd64.go
>  M src/pkg/syscall/zerrors_freebsd_386.go
>  M src/pkg/syscall/zerrors_freebsd_amd64.go
>  M src/pkg/syscall/zerrors_linux_386.go
>  M src/pkg/syscall/zerrors_linux_amd64.go
>  M src/pkg/syscall/zerrors_linux_arm.go
>  M src/pkg/syscall/zerrors_nacl_386.go
>  M src/pkg/syscall/zsyscall_darwin_386.go
>  M src/pkg/syscall/zsyscall_darwin_amd64.go
>  M src/pkg/syscall/zsyscall_freebsd_386.go
>  M src/pkg/syscall/zsyscall_freebsd_amd64.go
>  M src/pkg/syscall/zsyscall_linux_386.go
>  M src/pkg/syscall/zsyscall_linux_amd64.go
>  M src/pkg/syscall/zsyscall_linux_arm.go
>  M src/pkg/syscall/zsyscall_nacl_386.go
>  M src/pkg/syscall/zsysnum_darwin_386.go
>  M src/pkg/syscall/zsysnum_darwin_amd64.go
>  M src/pkg/syscall/zsysnum_freebsd_386.go
>  M src/pkg/syscall/zsysnum_freebsd_amd64.go
>  M src/pkg/syscall/zsysnum_linux_386.go
>  M src/pkg/syscall/zsysnum_linux_amd64.go
>  M src/pkg/syscall/zsysnum_linux_arm.go
>  M src/pkg/syscall/zsysnum_nacl_386.go
>  M src/pkg/syscall/ztypes_darwin_386.go
>  M src/pkg/syscall/ztypes_darwin_amd64.go
>  M src/pkg/syscall/ztypes_freebsd_386.go
>  M src/pkg/syscall/ztypes_freebsd_amd64.go
>  M src/pkg/syscall/ztypes_linux_386.go
>  M src/pkg/syscall/ztypes_linux_amd64.go
>  M src/pkg/syscall/ztypes_linux_arm.go
>  M src/pkg/syscall/ztypes_nacl_386.go
>
>
>

[gri, 2009-12-15 23:40:21]

*** Submitted as http://code.google.com/p/go/source/detail?r=23b6721e5813 ***

1) Change default gofmt default settings for
   parsing and printing to new syntax.

   Use -oldparser to parse the old syntax,
   use -oldprinter to print the old syntax.

2) Change default gofmt formatting settings
   to use tabs for indentation only and to use
   spaces for alignment. This will make the code
   alignment insensitive to an editor's tabwidth.

   Use -spaces=false to use tabs for alignment.

3) Manually changed src/exp/parser/parser_test.go
   so that it doesn't try to parse the parser's
   source files using the old syntax (they have
   new syntax now).

4) gofmt -w src misc test/bench

4th set of files.

R=rsc
CC=golang-dev
http://codereview.appspot.com/180049