Unified Diff: src/pkg/once/once.go
Issue 180049 :
code review 180049: 1) Change default gofmt default settings for (Closed)
Patch Set: code review 180049: 1) Change default gofmt default settings for
Use n/p to move between diff chunks;
N/P to move between comments.
Please Sign in to add in-line comments.
Jump to:
src/pkg/once/once.go
src/pkg/once/once_test.go
src/pkg/os/dir_darwin.go
src/pkg/os/dir_freebsd.go
src/pkg/os/dir_linux.go
src/pkg/os/dir_nacl.go
src/pkg/os/env.go
src/pkg/os/error.go
src/pkg/os/exec.go
src/pkg/os/file.go
src/pkg/os/getwd.go
src/pkg/os/os_test.go
src/pkg/os/path.go
src/pkg/os/path_test.go
src/pkg/os/proc.go
src/pkg/os/stat_darwin.go
src/pkg/os/stat_freebsd.go
src/pkg/os/stat_linux.go
src/pkg/os/stat_nacl.go
src/pkg/os/sys_darwin.go
src/pkg/os/sys_freebsd.go
src/pkg/os/sys_linux.go
src/pkg/os/sys_nacl.go
src/pkg/os/time.go
src/pkg/os/types.go
src/pkg/patch/apply.go
src/pkg/patch/git.go
src/pkg/patch/patch.go
src/pkg/patch/patch_test.go
src/pkg/patch/textdiff.go
src/pkg/path/path.go
src/pkg/path/path_test.go
src/pkg/rand/exp.go
src/pkg/rand/normal.go
src/pkg/rand/rand.go
src/pkg/rand/rand_test.go
src/pkg/rand/rng.go
src/pkg/reflect/all_test.go
src/pkg/reflect/deepequal.go
src/pkg/reflect/tostring_test.go
src/pkg/reflect/type.go
src/pkg/reflect/value.go
src/pkg/regexp/all_test.go
src/pkg/regexp/regexp.go
src/pkg/rpc/client.go
src/pkg/rpc/debug.go
src/pkg/rpc/server.go
src/pkg/rpc/server_test.go
src/pkg/runtime/type.go
src/pkg/sort/sort.go
src/pkg/sort/sort_test.go
src/pkg/strconv/atof.go
src/pkg/strconv/atof_test.go
src/pkg/strconv/atoi.go
src/pkg/strconv/atoi_test.go
src/pkg/strconv/decimal.go
src/pkg/strconv/decimal_test.go
src/pkg/strconv/fp_test.go
src/pkg/strconv/ftoa.go
src/pkg/strconv/ftoa_test.go
src/pkg/strconv/internal_test.go
src/pkg/strconv/itoa.go
src/pkg/strconv/itoa_test.go
src/pkg/strconv/quote.go
src/pkg/strconv/quote_test.go
src/pkg/strings/reader.go
src/pkg/strings/strings.go
src/pkg/strings/strings_test.go
src/pkg/sync/mutex.go
src/pkg/sync/mutex_test.go
src/pkg/sync/rwmutex.go
src/pkg/sync/rwmutex_test.go
src/pkg/syscall/errstr.go
src/pkg/syscall/exec.go
src/pkg/syscall/syscall.go
src/pkg/syscall/syscall_darwin.go
src/pkg/syscall/syscall_darwin_386.go
src/pkg/syscall/syscall_darwin_amd64.go
src/pkg/syscall/syscall_freebsd.go
src/pkg/syscall/syscall_freebsd_386.go
src/pkg/syscall/syscall_freebsd_amd64.go
src/pkg/syscall/syscall_linux.go
src/pkg/syscall/syscall_linux_386.go
src/pkg/syscall/syscall_linux_amd64.go
src/pkg/syscall/syscall_linux_arm.go
src/pkg/syscall/syscall_nacl.go
src/pkg/syscall/syscall_nacl_386.go
src/pkg/syscall/zerrors_darwin_386.go
src/pkg/syscall/zerrors_darwin_amd64.go
src/pkg/syscall/zerrors_freebsd_386.go
src/pkg/syscall/zerrors_freebsd_amd64.go
src/pkg/syscall/zerrors_linux_386.go
src/pkg/syscall/zerrors_linux_amd64.go
src/pkg/syscall/zerrors_linux_arm.go
src/pkg/syscall/zerrors_nacl_386.go
src/pkg/syscall/zsyscall_darwin_386.go
src/pkg/syscall/zsyscall_darwin_amd64.go
src/pkg/syscall/zsyscall_freebsd_386.go
src/pkg/syscall/zsyscall_freebsd_amd64.go
src/pkg/syscall/zsyscall_linux_386.go
src/pkg/syscall/zsyscall_linux_amd64.go
src/pkg/syscall/zsyscall_linux_arm.go
src/pkg/syscall/zsyscall_nacl_386.go
src/pkg/syscall/zsysnum_darwin_386.go
src/pkg/syscall/zsysnum_darwin_amd64.go
src/pkg/syscall/zsysnum_freebsd_386.go
src/pkg/syscall/zsysnum_freebsd_amd64.go
src/pkg/syscall/zsysnum_linux_386.go
src/pkg/syscall/zsysnum_linux_amd64.go
src/pkg/syscall/zsysnum_linux_arm.go
src/pkg/syscall/zsysnum_nacl_386.go
src/pkg/syscall/ztypes_darwin_386.go
src/pkg/syscall/ztypes_darwin_amd64.go
src/pkg/syscall/ztypes_freebsd_386.go
src/pkg/syscall/ztypes_freebsd_amd64.go
src/pkg/syscall/ztypes_linux_386.go
src/pkg/syscall/ztypes_linux_amd64.go
src/pkg/syscall/ztypes_linux_arm.go
src/pkg/syscall/ztypes_nacl_386.go
Index: src/pkg/once/once.go
===================================================================
--- a/src/pkg/once/once.go
+++ b/src/pkg/once/once.go
@@ -9,8 +9,8 @@
import "sync"
type job struct {
- done bool;
- sync.Mutex; // should probably be sync.Notification or some such
+ done bool
+ sync.Mutex // should probably be sync.Notification or some such
}
var jobs = make(map[func()]*job)
@@ -37,23 +37,23 @@
// because the func() expression in the first creates a new
// func each time f runs, and each of those funcs is run once.
func Do(f func()) {
- joblock.Lock();
- j, present := jobs[f];
+ joblock.Lock()
+ j, present := jobs[f]
if !present {
// run it
- j = new(job);
- j.Lock();
- jobs[f] = j;
- joblock.Unlock();
- f();
- j.done = true;
- j.Unlock();
+ j = new(job)
+ j.Lock()
+ jobs[f] = j
+ joblock.Unlock()
+ f()
+ j.done = true
+ j.Unlock()
} else {
// wait for it
- joblock.Unlock();
+ joblock.Unlock()
if j.done != true {
- j.Lock();
- j.Unlock();
+ j.Lock()
+ j.Unlock()
}
}
}