Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(983)

Issue 180047: code review 180047: 1) Change default gofmt default settings for (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 3 months ago by gri
Modified:
15 years, 3 months ago
Reviewers:
CC:
rsc, agl, golang-dev, iant, ken2, r
Visibility:
Public.

Description

1) Change default gofmt default settings for parsing and printing to new syntax. Use -oldparser to parse the old syntax, use -oldprinter to print the old syntax. 2) Change default gofmt formatting settings to use tabs for indentation only and to use spaces for alignment. This will make the code alignment insensitive to an editor's tabwidth. Use -spaces=false to use tabs for alignment. 3) Manually changed src/exp/parser/parser_test.go so that it doesn't try to parse the parser's source files using the old syntax (they have new syntax now). 4) gofmt -w src misc test/bench 1st set of files.

Patch Set 1 #

Patch Set 2 : code review 180047: 1) Change default gofmt default settings for #

Patch Set 3 : code review 180047: 1) Change default gofmt default settings for #

Patch Set 4 : code review 180047: 1) Change default gofmt default settings for #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9428 lines, -9428 lines) Patch
M misc/cgo/gmp/fib.go View 1 chunk +12 lines, -12 lines 0 comments Download
M misc/cgo/gmp/gmp.go View 7 chunks +94 lines, -94 lines 0 comments Download
M misc/cgo/gmp/pi.go View 1 chunk +31 lines, -31 lines 0 comments Download
M misc/cgo/stdio/chain.go View 2 chunks +15 lines, -15 lines 0 comments Download
M misc/cgo/stdio/fib.go View 1 chunk +17 lines, -17 lines 0 comments Download
M misc/cgo/stdio/file.go View 1 chunk +4 lines, -4 lines 0 comments Download
M src/cmd/cgo/ast.go View 8 chunks +115 lines, -115 lines 0 comments Download
M src/cmd/cgo/gcc.go View 21 chunks +205 lines, -205 lines 0 comments Download
M src/cmd/cgo/main.go View 3 chunks +30 lines, -30 lines 0 comments Download
M src/cmd/cgo/out.go View 1 2 3 2 chunks +85 lines, -85 lines 0 comments Download
M src/cmd/cgo/util.go View 2 chunks +37 lines, -37 lines 0 comments Download
M src/cmd/ebnflint/ebnflint.go View 5 chunks +27 lines, -27 lines 0 comments Download
M src/cmd/gc/runtime.go View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/godoc/godoc.go View 41 chunks +300 lines, -300 lines 0 comments Download
M src/cmd/godoc/index.go View 28 chunks +209 lines, -209 lines 0 comments Download
M src/cmd/godoc/main.go View 8 chunks +71 lines, -71 lines 0 comments Download
M src/cmd/godoc/snippet.go View 3 chunks +24 lines, -24 lines 0 comments Download
M src/cmd/godoc/spec.go View 4 chunks +61 lines, -61 lines 0 comments Download
M src/cmd/gofmt/gofmt.go View 1 2 3 10 chunks +59 lines, -59 lines 0 comments Download
M src/cmd/gofmt/rewrite.go View 9 chunks +65 lines, -65 lines 0 comments Download
M src/cmd/goyacc/goyacc.go View 89 chunks +906 lines, -906 lines 0 comments Download
M src/cmd/hgpatch/main.go View 8 chunks +134 lines, -134 lines 0 comments Download
M src/pkg/archive/tar/common.go View 2 chunks +36 lines, -36 lines 0 comments Download
M src/pkg/archive/tar/reader.go View 8 chunks +61 lines, -61 lines 0 comments Download
M src/pkg/archive/tar/reader_test.go View 6 chunks +56 lines, -56 lines 0 comments Download
M src/pkg/archive/tar/writer.go View 8 chunks +70 lines, -70 lines 0 comments Download
M src/pkg/archive/tar/writer_test.go View 3 chunks +33 lines, -33 lines 0 comments Download
M src/pkg/asn1/asn1.go View 21 chunks +227 lines, -227 lines 0 comments Download
M src/pkg/asn1/asn1_test.go View 20 chunks +77 lines, -77 lines 0 comments Download
M src/pkg/asn1/common.go View 5 chunks +36 lines, -36 lines 0 comments Download
M src/pkg/asn1/marshal.go View 9 chunks +97 lines, -97 lines 0 comments Download
M src/pkg/asn1/marshal_test.go View 2 chunks +17 lines, -17 lines 0 comments Download
M src/pkg/big/arith.go View 9 chunks +125 lines, -125 lines 0 comments Download
M src/pkg/big/arith_test.go View 14 chunks +74 lines, -74 lines 0 comments Download
M src/pkg/big/int.go View 12 chunks +118 lines, -118 lines 0 comments Download
M src/pkg/big/int_test.go View 26 chunks +121 lines, -121 lines 0 comments Download
M src/pkg/big/nat.go View 1 2 3 28 chunks +176 lines, -176 lines 0 comments Download
M src/pkg/big/nat_test.go View 12 chunks +50 lines, -50 lines 0 comments Download
M src/pkg/bignum/arith.go View 4 chunks +36 lines, -36 lines 0 comments Download
M src/pkg/bignum/bignum.go View 39 chunks +243 lines, -243 lines 0 comments Download
M src/pkg/bignum/bignum_test.go View 14 chunks +297 lines, -297 lines 0 comments Download
M src/pkg/bignum/integer.go View 25 chunks +75 lines, -75 lines 0 comments Download
M src/pkg/bignum/nrdiv_test.go View 6 chunks +50 lines, -50 lines 0 comments Download
M src/pkg/bignum/rational.go View 7 chunks +41 lines, -41 lines 0 comments Download
M src/pkg/bufio/bufio.go View 19 chunks +147 lines, -147 lines 0 comments Download
M src/pkg/bufio/bufio_test.go View 13 chunks +104 lines, -104 lines 0 comments Download
M src/pkg/bytes/buffer.go View 10 chunks +60 lines, -60 lines 0 comments Download
M src/pkg/bytes/buffer_test.go View 5 chunks +85 lines, -85 lines 0 comments Download
M src/pkg/bytes/bytes.go View 10 chunks +100 lines, -100 lines 0 comments Download
M src/pkg/bytes/bytes_test.go View 1 2 3 23 chunks +103 lines, -103 lines 0 comments Download
M src/pkg/compress/flate/deflate.go View 10 chunks +152 lines, -152 lines 0 comments Download
M src/pkg/compress/flate/deflate_test.go View 4 chunks +30 lines, -30 lines 0 comments Download
M src/pkg/compress/flate/flate_test.go View 4 chunks +12 lines, -12 lines 0 comments Download
M src/pkg/compress/flate/huffman_bit_writer.go View 11 chunks +188 lines, -188 lines 0 comments Download
M src/pkg/compress/flate/huffman_code.go View 9 chunks +120 lines, -120 lines 0 comments Download
M src/pkg/compress/flate/inflate.go View 22 chunks +170 lines, -170 lines 0 comments Download
M src/pkg/compress/flate/token.go View 4 chunks +13 lines, -13 lines 0 comments Download
M src/pkg/compress/flate/util.go View 2 chunks +7 lines, -7 lines 0 comments Download
M src/pkg/compress/gzip/gunzip.go View 7 chunks +70 lines, -70 lines 0 comments Download
M src/pkg/compress/gzip/gunzip_test.go View 10 chunks +27 lines, -27 lines 0 comments Download
M src/pkg/compress/zlib/reader.go View 5 chunks +29 lines, -29 lines 0 comments Download
M src/pkg/compress/zlib/reader_test.go View 2 chunks +17 lines, -17 lines 0 comments Download
M src/pkg/compress/zlib/writer.go View 5 chunks +34 lines, -34 lines 0 comments Download
M src/pkg/compress/zlib/writer_test.go View 2 chunks +43 lines, -43 lines 0 comments Download
M src/pkg/container/heap/heap.go View 5 chunks +23 lines, -23 lines 0 comments Download
M src/pkg/container/heap/heap_test.go View 4 chunks +48 lines, -48 lines 0 comments Download
M src/pkg/container/list/list.go View 10 chunks +58 lines, -58 lines 0 comments Download
M src/pkg/container/list/list_test.go View 5 chunks +64 lines, -64 lines 0 comments Download
M src/pkg/container/ring/ring.go View 8 chunks +31 lines, -31 lines 0 comments Download
M src/pkg/container/ring/ring_test.go View 4 chunks +83 lines, -83 lines 0 comments Download
M src/pkg/container/vector/intvector.go View 5 chunks +17 lines, -17 lines 0 comments Download
M src/pkg/container/vector/stringvector.go View 5 chunks +16 lines, -16 lines 0 comments Download
M src/pkg/container/vector/vector.go View 8 chunks +55 lines, -55 lines 0 comments Download
M src/pkg/container/vector/vector_test.go View 14 chunks +85 lines, -85 lines 0 comments Download
M src/pkg/crypto/aes/aes_test.go View 1 2 3 13 chunks +66 lines, -66 lines 0 comments Download
M src/pkg/crypto/aes/block.go View 3 chunks +67 lines, -67 lines 0 comments Download
M src/pkg/crypto/aes/cipher.go View 4 chunks +12 lines, -12 lines 0 comments Download
M src/pkg/crypto/aes/const.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/crypto/block/cbc.go View 1 chunk +18 lines, -18 lines 0 comments Download
M src/pkg/crypto/block/cbc_aes_test.go View 2 chunks +21 lines, -21 lines 0 comments Download
M src/pkg/crypto/block/cfb.go View 4 chunks +19 lines, -19 lines 0 comments Download
M src/pkg/crypto/block/cfb_aes_test.go View 2 chunks +22 lines, -22 lines 0 comments Download
M src/pkg/crypto/block/cipher.go View 2 chunks +11 lines, -11 lines 0 comments Download
M src/pkg/crypto/block/cmac.go View 8 chunks +27 lines, -27 lines 0 comments Download
M src/pkg/crypto/block/cmac_aes_test.go View 2 chunks +16 lines, -16 lines 0 comments Download
M src/pkg/crypto/block/ctr.go View 1 chunk +12 lines, -12 lines 0 comments Download
M src/pkg/crypto/block/ctr_aes_test.go View 3 chunks +23 lines, -23 lines 0 comments Download
M src/pkg/crypto/block/eax.go View 10 chunks +80 lines, -80 lines 0 comments Download
M src/pkg/crypto/block/eax_aes_test.go View 3 chunks +23 lines, -23 lines 0 comments Download
M src/pkg/crypto/block/ecb.go View 10 chunks +72 lines, -72 lines 0 comments Download
M src/pkg/crypto/block/ecb_aes_test.go View 2 chunks +20 lines, -20 lines 0 comments Download
M src/pkg/crypto/block/ecb_test.go View 4 chunks +48 lines, -48 lines 0 comments Download
M src/pkg/crypto/block/ofb.go View 1 chunk +10 lines, -10 lines 0 comments Download
M src/pkg/crypto/block/ofb_aes_test.go View 3 chunks +23 lines, -23 lines 0 comments Download
M src/pkg/crypto/block/xor.go View 4 chunks +46 lines, -46 lines 0 comments Download
M src/pkg/crypto/block/xor_test.go View 2 chunks +51 lines, -51 lines 0 comments Download
M src/pkg/crypto/hmac/hmac.go View 3 chunks +29 lines, -29 lines 0 comments Download
M src/pkg/crypto/hmac/hmac_test.go View 2 chunks +14 lines, -14 lines 0 comments Download
M src/pkg/crypto/md4/md4.go View 2 chunks +49 lines, -49 lines 0 comments Download
M src/pkg/crypto/md4/md4_test.go View 2 chunks +12 lines, -12 lines 0 comments Download
M src/pkg/crypto/md4/md4block.go View 2 chunks +38 lines, -38 lines 0 comments Download
M src/pkg/crypto/md5/md5.go View 2 chunks +49 lines, -49 lines 0 comments Download
M src/pkg/crypto/md5/md5_test.go View 2 chunks +12 lines, -12 lines 0 comments Download
M src/pkg/crypto/md5/md5block.go View 2 chunks +52 lines, -52 lines 0 comments Download
M src/pkg/crypto/rc4/rc4.go View 3 chunks +15 lines, -15 lines 0 comments Download
M src/pkg/crypto/rc4/rc4_test.go View 2 chunks +10 lines, -10 lines 0 comments Download
M src/pkg/crypto/rsa/pkcs1v15.go View 8 chunks +76 lines, -76 lines 0 comments Download
M src/pkg/crypto/rsa/pkcs1v15_test.go View 8 chunks +52 lines, -52 lines 0 comments Download
M src/pkg/crypto/rsa/rsa.go View 1 2 3 9 chunks +149 lines, -149 lines 0 comments Download
M src/pkg/crypto/rsa/rsa_test.go View 5 chunks +34 lines, -34 lines 0 comments Download
M src/pkg/crypto/sha1/sha1.go View 2 chunks +51 lines, -51 lines 0 comments Download
M src/pkg/crypto/sha1/sha1_test.go View 2 chunks +12 lines, -12 lines 0 comments Download
M src/pkg/crypto/sha1/sha1block.go View 1 chunk +41 lines, -41 lines 0 comments Download
M src/pkg/crypto/sha256/sha256.go View 2 chunks +57 lines, -57 lines 0 comments Download
M src/pkg/crypto/sha256/sha256_test.go View 2 chunks +12 lines, -12 lines 0 comments Download
M src/pkg/crypto/sha256/sha256block.go View 1 chunk +31 lines, -31 lines 0 comments Download
M src/pkg/crypto/subtle/constant_time.go View 1 chunk +18 lines, -18 lines 0 comments Download
M src/pkg/crypto/subtle/constant_time_test.go View 7 chunks +15 lines, -15 lines 0 comments Download
M src/pkg/crypto/tls/alert.go View 1 chunk +26 lines, -26 lines 0 comments Download
M src/pkg/crypto/tls/ca_set.go View 6 chunks +12 lines, -12 lines 0 comments Download
M src/pkg/crypto/tls/common.go View 3 chunks +43 lines, -43 lines 0 comments Download
M src/pkg/crypto/tls/handshake_client.go View 3 chunks +116 lines, -116 lines 0 comments Download
M src/pkg/crypto/tls/handshake_messages.go View 7 chunks +140 lines, -140 lines 0 comments Download
M src/pkg/crypto/tls/handshake_messages_test.go View 3 chunks +54 lines, -54 lines 0 comments Download
M src/pkg/crypto/tls/handshake_server.go View 4 chunks +106 lines, -106 lines 0 comments Download
M src/pkg/crypto/tls/handshake_server_test.go View 4 chunks +81 lines, -81 lines 0 comments Download
M src/pkg/crypto/tls/prf.go View 4 chunks +71 lines, -71 lines 0 comments Download
M src/pkg/crypto/tls/prf_test.go View 3 chunks +22 lines, -22 lines 0 comments Download
M src/pkg/crypto/tls/record_process.go View 8 chunks +107 lines, -107 lines 0 comments Download
M src/pkg/crypto/tls/record_process_test.go View 1 chunk +69 lines, -69 lines 0 comments Download
M src/pkg/crypto/tls/record_read.go View 1 chunk +10 lines, -10 lines 0 comments Download
M src/pkg/crypto/tls/record_read_test.go View 3 chunks +19 lines, -19 lines 0 comments Download
M src/pkg/crypto/tls/record_write.go View 5 chunks +66 lines, -66 lines 0 comments Download
M src/pkg/crypto/tls/tls.go View 6 chunks +70 lines, -70 lines 0 comments Download
M src/pkg/crypto/x509/x509.go View 20 chunks +170 lines, -170 lines 0 comments Download
M src/pkg/crypto/x509/x509_test.go View 5 chunks +20 lines, -20 lines 0 comments Download
M src/pkg/crypto/xtea/block.go View 1 chunk +23 lines, -23 lines 0 comments Download
M src/pkg/crypto/xtea/cipher.go View 5 chunks +20 lines, -20 lines 0 comments Download
M src/pkg/crypto/xtea/xtea_test.go View 8 chunks +58 lines, -58 lines 0 comments Download

Messages

Total messages: 3
gri
Hello rsc (cc: agl, golang-dev@googlegroups.com, gri, iant, ken2, r), I'd like you to review the ...
15 years, 3 months ago (2009-12-15 22:45:14 UTC) #1
rsc
LGTM I looked at all the files.
15 years, 3 months ago (2009-12-15 23:13:54 UTC) #2
gri
15 years, 3 months ago (2009-12-15 23:33:36 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=ccace91ba730 ***

               1) Change default gofmt default settings for
                  parsing and printing to new syntax.

                  Use -oldparser to parse the old syntax,
                  use -oldprinter to print the old syntax.

               2) Change default gofmt formatting settings
                  to use tabs for indentation only and to use
                  spaces for alignment. This will make the code
                  alignment insensitive to an editor's tabwidth.

                  Use -spaces=false to use tabs for alignment.

               3) Manually changed src/exp/parser/parser_test.go
                  so that it doesn't try to parse the parser's
                  source files using the old syntax (they have
                  new syntax now).

               4) gofmt -w src misc test/bench

	       1st set of files.

R=rsc
CC=agl, golang-dev, iant, ken2, r
http://codereview.appspot.com/180047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b