Issue 1799042: code review 1799042: Remove zsyscall file edits

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1799042: code review 1799042: Remove zsyscall file edits

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by peterGo

Modified:
13 years, 6 months ago

Reviewers:

CC:
golang-dev

Visibility:
Public.

Description

Remove zsyscall file edits CL 1319042: Added socketpair syscall and net.Socketpair edited zsyscall files. Warning message ignored. MACHINE GENERATED BY THE COMMAND ABOVE; DO NOT EDIT Fixes issue 919

Patch Set 1 #

Patch Set 2 : code review 1799042: Remove zsyscall file edits #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -50 lines)			Patch
M	src/pkg/syscall/syscall_bsd.go	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/syscall_linux_amd64.go	View	1	2 chunks	+12 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/syscall_linux_arm.go	View		2 chunks	+12 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_darwin_386.go	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_darwin_amd64.go	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_freebsd_386.go	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_freebsd_amd64.go	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_linux_amd64.go	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_linux_arm.go	View		1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

peterGo

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

13 years, 9 months ago (2010-07-14 21:55:42 UTC) #1

fixed independently; sorry for the pain

Expand All Messages | Collapse All Messages