Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1810)

Issue 179700043: code review 179700043: go1.4rc2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 3 months ago by adg
Modified:
6 years, 3 months ago
Reviewers:
minux, rsc
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

go1.4rc2

Patch Set 1 #

Patch Set 2 : diff -r 9e6afb82e1eb6b2b3a58ceb362bde1d5c4fb6831 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M VERSION View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
adg
Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
6 years, 3 months ago (2014-12-02 02:36:08 UTC) #1
rsc
LGTM
6 years, 3 months ago (2014-12-02 02:42:30 UTC) #2
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=6c4e66ae7137 *** go1.4rc2 LGTM=rsc R=rsc CC=golang-codereviews https://codereview.appspot.com/179700043
6 years, 3 months ago (2014-12-02 02:43:46 UTC) #3
minux
Have you considered CL 180380043?
6 years, 3 months ago (2014-12-02 02:44:34 UTC) #4
rsc
On Mon, Dec 1, 2014 at 9:44 PM, minux <minux@golang.org> wrote: > Have you considered ...
6 years, 3 months ago (2014-12-02 03:00:36 UTC) #5
minux
6 years, 3 months ago (2014-12-02 03:04:28 UTC) #6
On Dec 1, 2014 10:00 PM, "Russ Cox" <rsc@golang.org> wrote:
> On Mon, Dec 1, 2014 at 9:44 PM, minux <minux@golang.org> wrote:
>> Have you considered CL 180380043?
>
> I haven't gotten through my Thanksgiving email backlog for golang.org
yet. I have been spending all my Go time finding that GC bug. I hope to get
to it tomorrow. It's still possible to get into the release even though
it's not in rc2.
Understood. Getting rc2 out soon with the critical GC bug fix is more
important than the pprof usability fix, which I believe don't need a rc.

Thanks.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b