Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(902)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 179290043: [dev.garbage] code review 179290043: all: merge dev.cc (493ad916c3b1) into dev.garbage (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by rsc
Modified:
10 years, 3 months ago
Reviewers:
austin
CC:
golang-codereviews
Visibility:
Public.

Description

all: merge dev.cc (493ad916c3b1) into dev.garbage

Patch Set 1 #

Patch Set 2 : diff -r d533fb122f4d3ed5b180ec9f411c6a0147bbe32d https://code.google.com/p/go/ #

Patch Set 3 : diff -r d533fb122f4d3ed5b180ec9f411c6a0147bbe32d https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5263 lines, -12765 lines) Patch
M .hgtags View 1 1 chunk +1 line, -0 lines 0 comments Download
M AUTHORS View 1 1 chunk +1 line, -1 line 0 comments Download
M CONTRIBUTORS View 1 2 chunks +2 lines, -1 line 0 comments Download
M doc/go1.4.html View 1 7 chunks +60 lines, -5 lines 0 comments Download
M doc/go_spec.html View 1 6 chunks +44 lines, -28 lines 0 comments Download
M doc/gopher/fiveyears.jpg View 1 Binary file 0 comments Download
M doc/install.html View 1 1 chunk +1 line, -1 line 0 comments Download
M include/link.h View 1 4 chunks +8 lines, -1 line 0 comments Download
M misc/makerelease/makerelease.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/cmd/5g/opt.h View 1 4 chunks +23 lines, -7 lines 0 comments Download
M src/cmd/5g/reg.c View 1 9 chunks +32 lines, -15 lines 0 comments Download
M src/cmd/5l/5.out.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/6g/opt.h View 1 5 chunks +24 lines, -8 lines 0 comments Download
M src/cmd/6g/reg.c View 1 7 chunks +29 lines, -14 lines 0 comments Download
M src/cmd/6l/6.out.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/8g/opt.h View 1 5 chunks +24 lines, -8 lines 0 comments Download
M src/cmd/8g/reg.c View 1 10 chunks +35 lines, -18 lines 0 comments Download
M src/cmd/8l/8.out.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/9a/lex.c View 1 2 chunks +2 lines, -1 line 0 comments Download
R src/cmd/9c/Makefile View 1 1 chunk +0 lines, -5 lines 0 comments Download
R src/cmd/9c/Notes View 1 1 chunk +0 lines, -14 lines 0 comments Download
R src/cmd/9c/cgen.c View 1 1 chunk +0 lines, -1147 lines 0 comments Download
R src/cmd/9c/doc.go View 1 1 chunk +0 lines, -17 lines 0 comments Download
R src/cmd/9c/gc.h View 1 1 chunk +0 lines, -350 lines 0 comments Download
R src/cmd/9c/list.c View 1 1 chunk +0 lines, -37 lines 0 comments Download
R src/cmd/9c/machcap.c View 1 1 chunk +0 lines, -105 lines 0 comments Download
R src/cmd/9c/mul.c View 1 1 chunk +0 lines, -638 lines 0 comments Download
R src/cmd/9c/peep.c View 1 1 chunk +0 lines, -1076 lines 0 comments Download
R src/cmd/9c/reg.c View 1 1 chunk +0 lines, -1163 lines 0 comments Download
R src/cmd/9c/sgen.c View 1 1 chunk +0 lines, -291 lines 0 comments Download
R src/cmd/9c/swt.c View 1 1 chunk +0 lines, -407 lines 0 comments Download
R src/cmd/9c/txt.c View 1 1 chunk +0 lines, -1537 lines 0 comments Download
M src/cmd/9g/prog.c View 1 1 chunk +5 lines, -4 lines 0 comments Download
M src/cmd/9g/reg.c View 1 2 chunks +2 lines, -5 lines 0 comments Download
M src/cmd/9l/9.out.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/cgo/doc.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/dist/build.c View 1 2 chunks +3 lines, -4 lines 0 comments Download
M src/cmd/dist/buildgc.c View 1 4 chunks +84 lines, -3 lines 0 comments Download
M src/cmd/dist/buildruntime.c View 1 1 chunk +0 lines, -60 lines 0 comments Download
M src/cmd/gc/walk.c View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/cmd/go/tool.go View 1 2 chunks +1 line, -11 lines 0 comments Download
M src/cmd/internal/goobj/read.go View 1 1 chunk +666 lines, -0 lines 0 comments Download
M src/cmd/internal/goobj/read_test.go View 1 1 chunk +28 lines, -0 lines 0 comments Download
M src/cmd/internal/objfile/goobj.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/link/auto.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/link/auto_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/link/dead.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/link/dead_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/link/layout.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/link/link_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/link/pclntab.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/link/pclntab_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/link/prog.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/link/runtime.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/link/scan.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/cmd/pprof/internal/report/source.go View 1 1 chunk +5 lines, -1 line 0 comments Download
M src/crypto/x509/root_unix.go View 1 1 chunk +1 line, -0 lines 0 comments Download
R src/debug/goobj/read.go View 1 1 chunk +0 lines, -666 lines 0 comments Download
R src/debug/goobj/read_test.go View 1 1 chunk +0 lines, -28 lines 0 comments Download
M src/go/parser/error_test.go View 1 7 chunks +13 lines, -14 lines 0 comments Download
M src/go/parser/parser_test.go View 1 10 chunks +9 lines, -11 lines 0 comments Download
M src/hash/crc32/crc32.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/image/jpeg/reader.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/image/jpeg/reader_test.go View 1 2 chunks +46 lines, -0 lines 0 comments Download
M src/liblink/list6.c View 1 2 chunks +38 lines, -0 lines 0 comments Download
M src/liblink/list9.c View 1 2 chunks +41 lines, -0 lines 0 comments Download
M src/net/http/fs.go View 1 1 chunk +6 lines, -2 lines 0 comments Download
M src/net/url/example_test.go View 1 2 chunks +30 lines, -0 lines 0 comments Download
M src/regexp/syntax/regexp.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/run.bash View 1 4 chunks +25 lines, -13 lines 0 comments Download
M src/run.bat View 1 1 chunk +5 lines, -3 lines 0 comments Download
M src/runtime/arch1_386.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/arch1_amd64.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/arch1_amd64p32.go View 1 1 chunk +15 lines, -0 lines 0 comments Download
M src/runtime/arch1_arm.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/arch1_power64.go View 1 1 chunk +15 lines, -0 lines 0 comments Download
M src/runtime/arch1_power64le.go View 1 1 chunk +15 lines, -0 lines 0 comments Download
R src/runtime/arch_amd64p32.h View 1 1 chunk +0 lines, -17 lines 0 comments Download
R src/runtime/arch_power64.h View 1 1 chunk +0 lines, -14 lines 0 comments Download
R src/runtime/arch_power64le.h View 1 1 chunk +0 lines, -14 lines 0 comments Download
M src/runtime/asm_amd64p32.s View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/asm_power64x.s View 1 5 chunks +25 lines, -34 lines 0 comments Download
M src/runtime/atomic_power64x.go View 1 1 chunk +69 lines, -0 lines 0 comments Download
M src/runtime/chan.go View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/defs1_netbsd_386.go View 1 3 chunks +17 lines, -5 lines 0 comments Download
M src/runtime/defs1_netbsd_amd64.go View 1 3 chunks +16 lines, -4 lines 0 comments Download
M src/runtime/defs_linux_386.go View 1 1 chunk +5 lines, -4 lines 0 comments Download
M src/runtime/defs_linux_amd64.go View 1 1 chunk +5 lines, -5 lines 0 comments Download
M src/runtime/defs_linux_arm.go View 1 1 chunk +5 lines, -4 lines 0 comments Download
R src/runtime/defs_linux_power64.h View 1 1 chunk +0 lines, -204 lines 0 comments Download
M src/runtime/defs_linux_power64.go View 1 1 chunk +198 lines, -0 lines 0 comments Download
R src/runtime/defs_linux_power64le.h View 1 1 chunk +0 lines, -204 lines 0 comments Download
M src/runtime/defs_linux_power64le.go View 1 1 chunk +198 lines, -0 lines 0 comments Download
M src/runtime/defs_plan9_386.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/defs_plan9_amd64.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/env_plan9.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/runtime/gengoos.go View 1 1 chunk +84 lines, -0 lines 0 comments Download
M src/runtime/heapdump.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/lfstack.go View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/runtime/lfstack_32bit.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/lfstack_linux_power64x.go View 1 1 chunk +13 lines, -7 lines 0 comments Download
M src/runtime/malloc.go View 1 2 chunks +9 lines, -2 lines 0 comments Download
M src/runtime/malloc2.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/mem_bsd.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
R src/runtime/mem_nacl.c View 1 1 chunk +0 lines, -120 lines 0 comments Download
R src/runtime/mem_plan9.c View 1 1 chunk +0 lines, -121 lines 0 comments Download
M src/runtime/mem_plan9.go View 1 1 chunk +70 lines, -0 lines 0 comments Download
M src/runtime/mgc0.go View 1 1 chunk +16 lines, -0 lines 0 comments Download
R src/runtime/netpoll_stub.c View 1 1 chunk +0 lines, -18 lines 0 comments Download
M src/runtime/netpoll_stub.go View 1 1 chunk +15 lines, -0 lines 0 comments Download
M src/runtime/netpoll_windows.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/os1_nacl.go View 1 1 chunk +140 lines, -258 lines 0 comments Download
M src/runtime/os1_netbsd.go View 1 2 chunks +166 lines, -272 lines 0 comments Download
M src/runtime/os1_netbsd_386.go View 1 1 chunk +16 lines, -0 lines 0 comments Download
M src/runtime/os1_netbsd_amd64.go View 1 1 chunk +16 lines, -0 lines 0 comments Download
M src/runtime/os1_plan9.go View 1 1 chunk +191 lines, -289 lines 0 comments Download
M src/runtime/os1_windows.go View 1 1 chunk +564 lines, -0 lines 0 comments Download
M src/runtime/os1_windows_386.go View 1 1 chunk +118 lines, -0 lines 0 comments Download
M src/runtime/os1_windows_amd64.go View 1 1 chunk +137 lines, -0 lines 0 comments Download
M src/runtime/os2_nacl.go View 1 1 chunk +154 lines, -0 lines 0 comments Download
M src/runtime/os2_netbsd.go View 1 1 chunk +18 lines, -0 lines 0 comments Download
M src/runtime/os2_plan9.go View 1 1 chunk +72 lines, -0 lines 0 comments Download
M src/runtime/os2_windows.go View 1 1 chunk +25 lines, -0 lines 0 comments Download
R src/runtime/os_android.h View 1 1 chunk +0 lines, -1 line 0 comments Download
R src/runtime/os_android.c View 1 1 chunk +0 lines, -16 lines 0 comments Download
M src/runtime/os_android_arm.go View 1 1 chunk +15 lines, -0 lines 0 comments Download
R src/runtime/os_nacl.h View 1 1 chunk +0 lines, -162 lines 0 comments Download
src/runtime/os_nacl.c View 1 1 chunk +0 lines, -315 lines 0 comments Download
M src/runtime/os_nacl.go View 1 2 chunks +16 lines, -5 lines 0 comments Download
R src/runtime/os_nacl_arm.c View 1 1 chunk +0 lines, -24 lines 0 comments Download
M src/runtime/os_nacl_arm.go View 1 1 chunk +17 lines, -0 lines 0 comments Download
R src/runtime/os_netbsd.h View 1 1 chunk +0 lines, -31 lines 0 comments Download
src/runtime/os_netbsd.c View 1 1 chunk +0 lines, -371 lines 0 comments Download
M src/runtime/os_netbsd.go View 1 1 chunk +27 lines, -5 lines 0 comments Download
R src/runtime/os_netbsd_386.c View 1 1 chunk +0 lines, -17 lines 0 comments Download
R src/runtime/os_netbsd_amd64.c View 1 1 chunk +0 lines, -18 lines 0 comments Download
R src/runtime/os_plan9.h View 1 1 chunk +0 lines, -93 lines 0 comments Download
src/runtime/os_plan9.c View 1 1 chunk +0 lines, -368 lines 0 comments Download
M src/runtime/os_plan9.go View 1 1 chunk +27 lines, -0 lines 0 comments Download
R src/runtime/os_plan9_386.c View 1 1 chunk +0 lines, -150 lines 0 comments Download
M src/runtime/os_plan9_386.go View 1 1 chunk +131 lines, -0 lines 0 comments Download
R src/runtime/os_plan9_amd64.c View 1 1 chunk +0 lines, -158 lines 0 comments Download
M src/runtime/os_plan9_amd64.go View 1 1 chunk +139 lines, -0 lines 0 comments Download
R src/runtime/os_windows.h View 1 1 chunk +0 lines, -42 lines 0 comments Download
R src/runtime/os_windows.c View 1 1 chunk +0 lines, -636 lines 0 comments Download
M src/runtime/os_windows.go View 1 1 chunk +0 lines, -16 lines 0 comments Download
R src/runtime/os_windows_386.c View 1 1 chunk +0 lines, -128 lines 0 comments Download
R src/runtime/os_windows_amd64.c View 1 1 chunk +0 lines, -150 lines 0 comments Download
M src/runtime/panic.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/proc.go View 1 3 chunks +17 lines, -5 lines 0 comments Download
M src/runtime/race/race_unix_test.go View 1 1 chunk +30 lines, -0 lines 0 comments Download
M src/runtime/race1.go View 1 3 chunks +34 lines, -3 lines 0 comments Download
M src/runtime/race_amd64.s View 1 3 chunks +37 lines, -6 lines 0 comments Download
M src/runtime/runtime2.go View 1 2 chunks +7 lines, -9 lines 0 comments Download
M src/runtime/select.go View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/runtime/sema.go View 1 2 chunks +2 lines, -0 lines 0 comments Download
R src/runtime/signal_android_386.h View 1 1 chunk +0 lines, -1 line 0 comments Download
R src/runtime/signal_android_arm.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/signal_linux_386.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/signal_linux_amd64.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/signal_linux_arm.go View 1 1 chunk +1 line, -1 line 0 comments Download
R src/runtime/signal_linux_power64.h View 1 1 chunk +0 lines, -49 lines 0 comments Download
R src/runtime/signal_linux_power64le.h View 1 1 chunk +0 lines, -49 lines 0 comments Download
M src/runtime/signal_linux_power64x.go View 1 1 chunk +71 lines, -0 lines 0 comments Download
M src/runtime/signal_nacl.go View 1 1 chunk +45 lines, -0 lines 0 comments Download
R src/runtime/signal_nacl_386.h View 1 1 chunk +0 lines, -23 lines 0 comments Download
M src/runtime/signal_nacl_386.go View 1 1 chunk +34 lines, -0 lines 0 comments Download
R src/runtime/signal_nacl_amd64p32.h View 1 1 chunk +0 lines, -31 lines 0 comments Download
M src/runtime/signal_nacl_amd64p32.go View 1 1 chunk +44 lines, -0 lines 0 comments Download
R src/runtime/signal_nacl_arm.h View 1 1 chunk +0 lines, -28 lines 0 comments Download
M src/runtime/signal_nacl_arm.go View 1 1 chunk +47 lines, -0 lines 0 comments Download
M src/runtime/signal_netbsd.go View 1 1 chunk +46 lines, -0 lines 0 comments Download
R src/runtime/signal_netbsd_386.h View 1 1 chunk +0 lines, -23 lines 0 comments Download
M src/runtime/signal_netbsd_386.go View 1 1 chunk +38 lines, -0 lines 0 comments Download
R src/runtime/signal_netbsd_amd64.h View 1 1 chunk +0 lines, -31 lines 0 comments Download
M src/runtime/signal_netbsd_amd64.go View 1 1 chunk +48 lines, -0 lines 0 comments Download
M src/runtime/signal_plan9.go View 1 1 chunk +54 lines, -0 lines 0 comments Download
R src/runtime/signal_power64x.c View 1 1 chunk +0 lines, -137 lines 0 comments Download
M src/runtime/signal_power64x.go View 1 1 chunk +144 lines, -0 lines 0 comments Download
R src/runtime/signals_android.h View 1 1 chunk +0 lines, -1 line 0 comments Download
R src/runtime/signals_nacl.h View 1 1 chunk +0 lines, -53 lines 0 comments Download
R src/runtime/signals_netbsd.h View 1 1 chunk +0 lines, -54 lines 0 comments Download
R src/runtime/signals_plan9.h View 1 1 chunk +0 lines, -63 lines 0 comments Download
M src/runtime/stack1.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/stack2.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/stubs.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/stubs2.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/runtime/stubs3.go View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/runtime/sys_linux_power64x.s View 1 1 chunk +2 lines, -1 line 0 comments Download
R src/runtime/sys_power64x.c View 1 1 chunk +0 lines, -38 lines 0 comments Download
M src/runtime/sys_power64x.go View 1 1 chunk +37 lines, -0 lines 0 comments Download
M src/runtime/sys_windows_386.s View 1 7 chunks +8 lines, -8 lines 0 comments Download
M src/runtime/sys_windows_amd64.s View 1 6 chunks +7 lines, -7 lines 0 comments Download
M src/runtime/syscall_windows.go View 1 3 chunks +7 lines, -11 lines 0 comments Download
M src/runtime/zgoarch_386.go View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/runtime/zgoarch_amd64.go View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/runtime/zgoarch_amd64p32.go View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/runtime/zgoarch_arm.go View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/runtime/zgoarch_power64.go View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/runtime/zgoarch_power64le.go View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/runtime/zgoos_android.go View 1 1 chunk +17 lines, -0 lines 0 comments Download
M src/runtime/zgoos_darwin.go View 1 1 chunk +17 lines, -0 lines 0 comments Download
M src/runtime/zgoos_dragonfly.go View 1 1 chunk +17 lines, -0 lines 0 comments Download
M src/runtime/zgoos_freebsd.go View 1 1 chunk +17 lines, -0 lines 0 comments Download
M src/runtime/zgoos_linux.go View 1 1 chunk +19 lines, -0 lines 0 comments Download
M src/runtime/zgoos_nacl.go View 1 1 chunk +17 lines, -0 lines 0 comments Download
M src/runtime/zgoos_netbsd.go View 1 1 chunk +17 lines, -0 lines 0 comments Download
M src/runtime/zgoos_openbsd.go View 1 1 chunk +17 lines, -0 lines 0 comments Download
M src/runtime/zgoos_plan9.go View 1 1 chunk +17 lines, -0 lines 0 comments Download
M src/runtime/zgoos_solaris.go View 1 1 chunk +17 lines, -0 lines 0 comments Download
M src/runtime/zgoos_windows.go View 1 1 chunk +17 lines, -0 lines 0 comments Download
M src/syscall/exec_bsd.go View 1 3 chunks +2 lines, -38 lines 0 comments Download
M src/syscall/exec_linux.go View 1 3 chunks +1 line, -35 lines 0 comments Download
M test/fixedbugs/issue9110.go View 1 1 chunk +90 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello austin (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.garbage branch ...
10 years, 3 months ago (2014-11-24 17:07:09 UTC) #1
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=640e39ec202b *** [dev.garbage] all: merge dev.cc (493ad916c3b1) into dev.garbage TBR=austin CC=golang-codereviews https://codereview.appspot.com/179290043
10 years, 3 months ago (2014-11-24 17:07:19 UTC) #2
austin
10 years, 3 months ago (2014-11-24 19:20:58 UTC) #3
Message was sent while issue was closed. 
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b