Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(671)

Issue 177640043: Issue 4211: Add an alternative quarter rest shaped like a mirrored Z. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 3 months ago by Dan Eble
Modified:
9 years, 3 months ago
Reviewers:
lemzwerg, mail
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

For example, see G. Ricordi's edition of Don Pasquale by G. Donizetti, Atto Primo, Introduzione, measure 4, bass staff: http://javanese.imslp.info/files/imglnks/usimg/1/1a/IMSLP141736-PMLP58429-Donizetti_-_Don_Pasquale_VS_Sibley.1802.16329.pdf Many other quarter rests in the same score look slightly different. This new rest is designed to fit in with the other rests in the Feta font rather than to reproduce a particular historical look exactly.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Show labels optionally #

Total comments: 1

Patch Set 3 : Whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -4 lines) Patch
M input/regression/rest-dot-position.ly View 1 chunk +14 lines, -3 lines 0 comments Download
M input/regression/rest-note-collision.ly View 2 chunks +13 lines, -1 line 0 comments Download
M mf/feta-rests.mf View 1 2 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 6
Dan Eble
I revised the glyph again after I saw how it looked with a dot next ...
9 years, 3 months ago (2014-12-02 00:41:57 UTC) #1
lemzwerg
LGTM, thanks! https://codereview.appspot.com/177640043/diff/1/mf/feta-rests.mf File mf/feta-rests.mf (right): https://codereview.appspot.com/177640043/diff/1/mf/feta-rests.mf#newcode416 mf/feta-rests.mf:416: labels (9, 12); Please remove those two ...
9 years, 3 months ago (2014-12-02 07:20:07 UTC) #2
Dan Eble
Show labels optionally
9 years, 3 months ago (2014-12-02 14:08:57 UTC) #3
lemzwerg
https://codereview.appspot.com/177640043/diff/20001/mf/feta-rests.mf File mf/feta-rests.mf (right): https://codereview.appspot.com/177640043/diff/20001/mf/feta-rests.mf#newcode438 mf/feta-rests.mf:438: rest := rest xscaled -1 shifted (w, 0); Please ...
9 years, 3 months ago (2014-12-02 18:59:56 UTC) #4
Dan Eble
Whitespace
9 years, 3 months ago (2014-12-02 23:03:38 UTC) #5
mail_philholmes.net
9 years, 3 months ago (2014-12-03 09:30:58 UTC) #6
----- Original Message ----- 
From: <lemzwerg@googlemail.com>
To: <nine.fierce.ballads@gmail.com>
Cc: <reply@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org>
Sent: Tuesday, December 02, 2014 6:59 PM
Subject: Re: Issue 4211: Add an alternative quarter rest shaped like 
amirrored Z. (issue 177640043 by nine.fierce.ballads@gmail.com)


>
> https://codereview.appspot.com/177640043/diff/20001/mf/feta-rests.mf
> File mf/feta-rests.mf (right):
>
>
https://codereview.appspot.com/177640043/diff/20001/mf/feta-rests.mf#newcode438
> mf/feta-rests.mf:438: rest := rest xscaled -1 shifted (w, 0);
> Please use tabs for indentation

Explained here:

http://lilypond.org/doc/v2.19/Documentation/contributor/metafont-formatting-r...

--
Phil Holmes 

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b