Issue 177220044: [dev.cc] code review 177220044: all: merge default (95f5614b4648) into dev.cc

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 177220044: [dev.cc] code review 177220044: all: merge default (95f5614b4648) into dev.cc (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by rsc

Modified:
10 years, 8 months ago

Reviewers:
minux, austin

CC:
golang-codereviews

Visibility:
Public.

Description

all: merge default (95f5614b4648) into dev.cc

Patch Set 2 : diff -r cba220e281390b81de65db096915b095f97e470b https://code.google.com/p/go #

Patch Set 3 : diff -r cba220e281390b81de65db096915b095f97e470b https://code.google.com/p/go #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -36 lines)			Patch
M	src/cmd/go/tool.go	View	1	2 chunks	+1 line, -11 lines	0 comments	Download
M	src/go/parser/error_test.go	View	1	7 chunks	+13 lines, -14 lines	0 comments	Download
M	src/go/parser/parser_test.go	View	1	10 chunks	+9 lines, -11 lines	0 comments	Download
M	src/image/jpeg/reader.go	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/image/jpeg/reader_test.go	View	1	2 chunks	+46 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello austin (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.cc branch ...

10 years, 8 months ago (2014-11-23 20:13:56 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=493ad916c3b1 *** [dev.cc] all: merge default (95f5614b4648) into dev.cc TBR=austin CC=golang-codereviews https://codereview.appspot.com/177220044

10 years, 8 months ago (2014-11-23 20:14:11 UTC) #2

Message was sent while issue was closed.

LGTM

Expand All Messages | Collapse All Messages