Issue 176750043: [dev.cc] code review 176750043: runtime: convert dragonfly/amd64 port to Go

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 176750043: [dev.cc] code review 176750043: runtime: convert dragonfly/amd64 port to Go (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by jsing

Modified:
10 years, 6 months ago

Reviewers:
rsc

CC:
golang-codereviews, rsc

Visibility:
Public.

Description

runtime: convert dragonfly/amd64 port to Go

Patch Set 1 #

Patch Set 2 : diff -r b8329e8fce1a13ec34f9cf6a0a0db75c08cbc5ca https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b8329e8fce1a13ec34f9cf6a0a0db75c08cbc5ca https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 56f3a790b67aff99cc0aa47b7d880fa1bd3b176b https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 3949acfe175a61907aefe45b5f6b3dac83e14876 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 3de163a7c8240382023e7f508163e55aeeb89fff https://go.googlecode.com/hg/ #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+315 lines, -392 lines)			Patch
M	src/runtime/defs_dragonfly_amd64.go	View	1	5 chunks	+44 lines, -36 lines	0 comments	Download
M	src/runtime/os1_dragonfly.go	View	1	1 chunk	+160 lines, -252 lines	0 comments	Download
M	src/runtime/os2_dragonfly.go	View	1 2	1 chunk	+7 lines, -25 lines	0 comments	Download
M	src/runtime/os_dragonfly.go	View	1	1 chunk	+27 lines, -7 lines	0 comments	Download
M	src/runtime/signal_dragonfly.go	View	1	1 chunk	+40 lines, -48 lines	0 comments	Download
M	src/runtime/signal_dragonfly_amd64.go	View	1	1 chunk	+37 lines, -24 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

jsing

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to the dev.cc branch of https://go.googlecode.com/hg/

10 years, 6 months ago (2014-11-14 14:33:39 UTC) #1

jsing

Hello golang-codereviews@googlegroups.com, rsc@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.

10 years, 6 months ago (2014-11-14 16:55:51 UTC) #2

jsing

10 years, 6 months ago (2014-11-14 17:47:31 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=9e4038f249b2 ***

[dev.cc] runtime: convert dragonfly/amd64 port to Go

LGTM=rsc
R=golang-codereviews, rsc
CC=golang-codereviews
https://codereview.appspot.com/176750043

Expand All Messages | Collapse All Messages